-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Fix enabled virtual node addon showing wrong status in aks addon list
#5099
Conversation
fixes Azure#5098 az aks addon list command always returns "enable:false" for virtual-node addon. REST API returns "enable:true", but CLI displays result as "enable:false" ``` > az aks addon list -g TestRG -n TestCluster --debug # REST API returns the addon status to be "enabled:true" in debug trace. "addonProfiles": { "aciConnectorLinux": { "enabled": true, <<<<<<< "config": { "SubnetName": "VirtualNodeSubnet" }, #However, CLI displays "enabled:false". It appears to be matching with "aciConnector" instead of "aciConnectorLinux". { "api_key": "aciConnector", "enabled": false, <<<<<<<<< "name": "virtual-node" }, ```
AKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you please add a test for this case? |
By the way, please add the description of this change in the history notes |
aks addon list
I've opened a patch PR #5113 to add a test case for this modification. |
fixes #5098
az aks addon list command always returns "enable:false" for virtual-node addon. REST API returns "enable:true", but CLI displays result as "enable:false"
As per this and this source code we see that Linux is appended to the VirtualNode addon, so this check should be done while listing the addon:
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.