Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{AKS} support disabling Azure KeyVault KMS #5087

Merged
merged 1 commit into from
Jul 25, 2022
Merged

{AKS} support disabling Azure KeyVault KMS #5087

merged 1 commit into from
Jul 25, 2022

Conversation

bingosummer
Copy link
Member

@bingosummer bingosummer commented Jul 6, 2022 •
edited
Loading

  • Add a new parameter --disable-azure-keyvault-kms for az aks update.
  • Add tests for disabling KMS.

@ghost ghost requested review from zhoxing-ms and wangzelin007 July 6, 2022 07:31
@ghost ghost assigned zhoxing-ms Jul 6, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 6, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 6, 2022
@ghost ghost requested a review from yonzhan July 6, 2022 07:31
@ghost ghost added the AKS label Jul 6, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 6, 2022

AKS

@bingosummer bingosummer force-pushed the aks-disable-kms branch 3 times, most recently from 5dd57a4 to b6125dd Compare July 7, 2022 03:45
@bingosummer bingosummer force-pushed the aks-disable-kms branch 3 times, most recently from f7d6701 to 5eff54f Compare July 11, 2022 14:24
@bingosummer
Copy link
Member Author

@FumingZhang please have a review, thanks!

FumingZhang
FumingZhang approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingosummer
Copy link
Member Author

@zhoxing-ms could you please review and merge the PR? Thanks

@zhoxing-ms zhoxing-ms merged commit ca8d23c into Azure:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FumingZhang FumingZhang FumingZhang approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@zhoxing-ms zhoxing-ms

Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Milestone
Jul 2022 (2022-08-02)
Development

Successfully merging this pull request may close these issues.
4 participants
@bingosummer @yonzhan @zhoxing-ms @FumingZhang