Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix snapshot not resolved according to the subscriptions field in the --snapshot-id option #5070

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Fix the issue where snapshot is not resolved according to the subscriptions field in the --snapshot-id option. Otherwise, when the subscription specified by --snapshot-id is inconsistent with the currently logged in subscription, an attempt will be made to obtain the corresponding snapshot through the currently logged in subscription, resulting in an error that the resource cannot be found. See sibling PR #23077.

Related command

  • az aks create
  • az aks nodepool add

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 July 1, 2022 05:48
@ghost ghost assigned zhoxing-ms Jul 1, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 1, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 1, 2022
@ghost ghost requested a review from yonzhan July 1, 2022 05:48
@ghost ghost added the AKS label Jul 1, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review July 4, 2022 05:31
@zhoxing-ms zhoxing-ms merged commit a4b3033 into Azure:main Jul 5, 2022
@FumingZhang FumingZhang deleted the fuming/fix-snapshot-0701 branch July 12, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants