Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS-preview} Get aks monitoring MSI auth onboarding changes in-sync with azure cli #5065

Merged
merged 7 commits into from
Jul 7, 2022

Conversation

ganga1980
Copy link
Contributor

@ganga1980 ganga1980 commented Jun 30, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 June 30, 2022 07:03
@ghost ghost assigned zhoxing-ms Jun 30, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone Jun 30, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 30, 2022
@ghost ghost requested a review from yonzhan June 30, 2022 07:03
@ghost ghost added the AKS label Jun 30, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 30, 2022

AKS-preview

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/aks-preview/azext_aks_preview/addonconfiguration.py Outdated Show resolved Hide resolved
@ganga1980
Copy link
Contributor Author

Hi, @FumingZhang , can you please help on merging this PR?

@zhoxing-ms zhoxing-ms merged commit d082db1 into Azure:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants