Extending basic build support #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
added
the
|
container |
smurawski
force-pushed
the
basic_build_support
branch
from
0b7ed26 to
d7af8f1
Compare
|
@zhoxing-ms this pr is ready for review. Please let me know if there is anything else I need to do to release a new version. |
zhoxing-ms
reviewed
Jun 28, 2022
smurawski
force-pushed
the
basic_build_support
branch
2 times, most recently
from
55225ae to
6c37a09
Compare
smurawski
force-pushed
the
basic_build_support
branch
from
6c37a09 to
9206c5f
Compare
zhoxing-ms
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic build support (context and dockerfile) via Azure Container Registry (ACR) build tasks. If a service in the Compose file has the build key defined, either the provided ACR (or a new ACR which will be automatically provisioned) will be used to build the source container image. The container registry will be mapped the container app to finish the deployment scenario.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp compose
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.