Track onboarding sources using correlation_id parameter #5008
Conversation
sirireddy12
changed the title
|
connectedk8s |
| @@ -56,7 +56,7 @@ | |||
| # pylint: disable=line-too-long | |||
|
|
|||
|
|
|||
| def create_connectedk8s(cmd, client, resource_group_name, cluster_name, https_proxy="", http_proxy="", no_proxy="", proxy_cert="", location=None, | |||
| def create_connectedk8s(cmd, client, resource_group_name, cluster_name, correlation_id=None, https_proxy="", http_proxy="", no_proxy="", proxy_cert="", location=None, | |||
There was a problem hiding this comment.
It seems correlation_id not used in this function.
Can you double check?
There was a problem hiding this comment.
Hi @wangzelin007 , it is not used in the function, but it is needed as a parameter that should be exposed and it is being set/overridden from a validator. If this parameter is removed from this function, it is not being exposed as a parameter to the "connectedk8s connect" command
|
Please write the change of this PR into the history notes |
Done. Thanks! |
@zhoxing-ms Please review the PR |
@wangzelin007 @zhoxing-ms Thanks for merging it. Can you please release the latest version? |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.