{UpdateExtCommandTree} Support aaz commands #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairu-ms
commented
Jun 10, 2022
| @@ -44,8 +44,7 @@ def update_cmd_tree(ext_name): | |||
| az_cli.invocation = invoker | |||
|
|
|||
| sys.path.append(ext_dir) | |||
| extension_command_table, _ = _load_extension_command_loader(invoker.commands_loader, | |||
| "", ext_mod) | |||
| extension_command_table, _ = _load_extension_command_loader(invoker.commands_loader, None, ext_mod) | |||
There was a problem hiding this comment.
"" empty string will cause cut when loading command table for aaz commands. Replace it by None for fully load.
There was a problem hiding this comment.
Could you give some more info? I can't really understand the context. 😅
|
UpdateExtCommandTree |
wangzelin007
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to load aaz commands.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.