Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Trusted Access Role Binding CLI #4955

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

YitongFeng-git
Copy link
Contributor

@YitongFeng-git YitongFeng-git commented Jun 8, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

Test

Commands:
az aks trustedaccess rolebinding create -g yifetest --cluster-name yifeaks -n binding1 -s /subscriptions/8ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8/resourceGroups/yifetest/providers/Microsoft.MachineLearningServices/workspaces/yifeAML --roles Microsoft.MachineLearningServices/workspaces/reader Microsoft.MachineLearningServices/workspaces/writer

az aks trustedaccess rolebinding list -g yifetest --cluster-name yifeaks

az aks trustedaccess rolebinding show -g yifetest --cluster-name yifeaks -n binding1

az aks trustedaccess rolebinding delete -g yifetest --cluster-name yifeaks -n binding1

@ghost ghost requested review from zhoxing-ms and wangzelin007 June 8, 2022 03:49
@ghost ghost assigned zhoxing-ms Jun 8, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone Jun 8, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 8, 2022
@ghost ghost requested a review from yonzhan June 8, 2022 03:49
@ghost ghost added the AKS label Jun 8, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 8, 2022

AKS

@YitongFeng-git YitongFeng-git force-pushed the yife/binding branch 7 times, most recently from b920784 to e1ee74e Compare June 9, 2022 02:25
src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/_params.py Outdated Show resolved Hide resolved
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the format change caused by LF -> CRLF?

@YitongFeng-git YitongFeng-git force-pushed the yife/binding branch 4 times, most recently from 1f0ad60 to ea52c98 Compare June 9, 2022 05:47
@YitongFeng-git YitongFeng-git force-pushed the yife/binding branch 2 times, most recently from 14f8797 to 62c278c Compare June 9, 2022 07:28
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms
Copy link
Contributor

Could you add some tests for those new commands?

@FumingZhang
Copy link
Member

Could you add some tests for those new commands?

The resource has not been deployed to prod regions so currently there's no way to test the commands.

@YitongFeng-git YitongFeng-git force-pushed the yife/binding branch 3 times, most recently from 05aa9f8 to 1c8b55f Compare June 13, 2022 05:17
@karataliu
Copy link
Contributor

@wangzelin007 @zhoxing-ms could you help a merge?

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource has not been deployed to prod regions so currently there's no way to test the commands.

Please supplement relevant tests in the future PR

@zhoxing-ms zhoxing-ms merged commit dd950ef into Azure:main Jun 14, 2022
@YitongFeng-git YitongFeng-git deleted the yife/binding branch June 14, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants