-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove redundant --disable-workload-identity
#4871
refactor: remove redundant --disable-workload-identity
#4871
Conversation
6e48772
to
8f48eea
Compare
AKS |
--disable-workload-identity
--disable-workload-identity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve CI conflicting files first. |
…kload-identity-flag
Updated, PTAL @yonzhan |
Will removing parameter |
Thanks for the concern. Removing these flags won't impact current user as in AKS, this feature is not being enabled yet, only a small group of testers have access to it. So, removing it won't cause breaking change. |
@zhoxing-ms @yonzhan could you help merge this pr? Thanks! |
This pull request removed the redundant
--disable-workload-identity
flag from az aks create|update commands. Existing user can use--enable-workload-identity False
to archive such functionality.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.