-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Microsoft.SCVMM ] Requesting vmmserver credentials until non-empty #4863
[ Microsoft.SCVMM ] Requesting vmmserver credentials until non-empty #4863
Conversation
connectedvmware |
Co-authored-by: ZelinWang <[email protected]>
@zhoxing-ms , could you merge the PR if everything looks fine? |
src/scvmm/HISTORY.rst
Outdated
0.1.5 | ||
+++ | ||
* Requesting VMMServer credentials from the user until they are non-empty. | ||
* Removing default value for port. Asking for the input. If input is empty, setting port to 8100. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the default value will cause breaking change, right? If so, please add [BREAKING CHANGE]
as the prefix
* Removing default value for port. Asking for the input. If input is empty, setting port to 8100. | |
* [BREAKING CHANGE] Removing default value for port. Asking for the input. If input is empty, setting port to 8100. |
src/scvmm/HISTORY.rst
Outdated
|
||
0.1.5 | ||
+++ | ||
* Requesting VMMServer credentials from the user until they are non-empty. | ||
* Removing default value for port. Asking for the input. If input is empty, setting port to 8100. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, the history notes of new version should be written at the top, history notes should be arranged from new to old from top to bottom
while not creds['port']: | ||
print('Please provide vmmserver port (Default: 8100): ', end='') | ||
try: | ||
creds['port'] = input() | ||
if not creds['port']: | ||
creds['port'] = DEFAULT_VMMSERVER_PORT | ||
creds['port'] = int(creds['port']) | ||
except ValueError: | ||
print('Port must be a number, please try again') | ||
creds['port'] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the automation scenario, if the CLI script does not pass in the creds['port']
parameter, the process of CLI script will get stuck. Is this in line with expectations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is in line with the expectations. We will add modify the command by adding the new param to our automation pipelines.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.