Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Microsoft.SCVMM ] Requesting vmmserver credentials until non-empty #4863

Merged
merged 4 commits into from
Jun 5, 2022

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented May 20, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented May 20, 2022

connectedvmware

src/scvmm/HISTORY.rst Outdated Show resolved Hide resolved
Co-authored-by: ZelinWang <[email protected]>
@nascarsayan
Copy link
Contributor Author

@zhoxing-ms , could you merge the PR if everything looks fine?

0.1.5
+++
* Requesting VMMServer credentials from the user until they are non-empty.
* Removing default value for port. Asking for the input. If input is empty, setting port to 8100.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the default value will cause breaking change, right? If so, please add [BREAKING CHANGE] as the prefix

Suggested change
* Removing default value for port. Asking for the input. If input is empty, setting port to 8100.
* [BREAKING CHANGE] Removing default value for port. Asking for the input. If input is empty, setting port to 8100.

Comment on lines 29 to 33

0.1.5
+++
* Requesting VMMServer credentials from the user until they are non-empty.
* Removing default value for port. Asking for the input. If input is empty, setting port to 8100.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, the history notes of new version should be written at the top, history notes should be arranged from new to old from top to bottom

Comment on lines +109 to +118
while not creds['port']:
print('Please provide vmmserver port (Default: 8100): ', end='')
try:
creds['port'] = input()
if not creds['port']:
creds['port'] = DEFAULT_VMMSERVER_PORT
creds['port'] = int(creds['port'])
except ValueError:
print('Port must be a number, please try again')
creds['port'] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the automation scenario, if the CLI script does not pass in the creds['port'] parameter, the process of CLI script will get stuck. Is this in line with expectations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is in line with the expectations. We will add modify the command by adding the new param to our automation pipelines.

@zhoxing-ms zhoxing-ms merged commit e4fc380 into Azure:main Jun 5, 2022
@nascarsayan nascarsayan deleted the dev/snaskar/scvmm-user-prompt branch June 7, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants