Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Vendor 2022-04-02-preview for aks-preview #4796

Merged
merged 7 commits into from
May 10, 2022

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • Vendor 2022-04-02-preview for aks-preview.
  • Convert readme and history to rst format.
    • Tidy up readme.
    • Add description about release in history.
  • Need to fix
    • test_aks_create_with_monitoring_aad_auth_msi
    • test_aks_create_with_monitoring_aad_auth_uai
    • test_aks_nodepool_snapshot

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 May 10, 2022 07:40
@ghost ghost assigned zhoxing-ms May 10, 2022
@ghost ghost added this to the May 2022 (2022-05-24) milestone May 10, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label May 10, 2022
@ghost ghost requested a review from yonzhan May 10, 2022 07:40
@ghost ghost added the AKS label May 10, 2022
@zhoxing-ms zhoxing-ms merged commit 639af87 into Azure:main May 10, 2022
@FumingZhang FumingZhang deleted the fuming/aks-vendor-04-02-preview branch May 16, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants