Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Spring" extension and deprecate "Spring-Cloud" extension #4770

Merged
merged 13 commits into from
May 16, 2022

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented May 5, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Add new extension "spring" and mark the old extension "spring-cloud" as deprecated.
    image

  • The top-level command "spring-cloud" is hided, user can no longer see it when typing "az -h"

    image

  • The sub-level commands under "spring-cloud" is not hided.
    image

Related command

az spring
az spring-cloud

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost added Spring Cloud Spring Cloud related issues Auto-Assign Auto assign by bot labels May 5, 2022
@ghost ghost requested review from zhoxing-ms, wangzelin007 and yonzhan May 5, 2022 07:35
@ghost ghost assigned zhoxing-ms May 5, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 5, 2022

Spring

@yonzhan yonzhan added this to the May 2022 (2022-05-24) milestone May 5, 2022
@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 6, 2022

You may consider adding the public document link for spring migration to the help description of az spring-cloud and the message_func of deprecate_info.
Because the public document can help users better understand the context and background of this migration.

src/spring/HISTORY.md Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@zhoxing-ms zhoxing-ms merged commit 43670c5 into Azure:main May 16, 2022
@yuwzho yuwzho deleted the spring/rename branch May 18, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Spring Cloud Spring Cloud related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants