-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Firewall] az network firewall policy intrusion-detection add
: Add new parameter --private-ranges
#4764
[Azure Firewall] az network firewall policy intrusion-detection add
: Add new parameter --private-ranges
#4764
Conversation
network |
@diklatze, there are plenty of things missing, like no style and linter checks before submitting a PR, testing recordings don't exist either, etc. Please refer to: https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules for development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update HISTORY.rst and setup.py.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
az network firewall policy intrusion-detection add
: Add new parameter --private-ranges
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.