Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Firewall] az network firewall policy intrusion-detection add: Add new parameter --private-ranges #4764

Merged
merged 15 commits into from
May 16, 2022

Conversation

diklatze
Copy link
Contributor

@diklatze diklatze commented May 3, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@diklatze diklatze marked this pull request as ready for review May 3, 2022 13:37
@yonzhan yonzhan added this to the May 2022 (2022-05-24) milestone May 3, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 3, 2022

network

@necusjz
Copy link
Member

necusjz commented May 5, 2022

@diklatze, there are plenty of things missing, like no style and linter checks before submitting a PR, testing recordings don't exist either, etc. Please refer to: https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules for development.

Copy link
Member

@necusjz necusjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update HISTORY.rst and setup.py.

@necusjz
Copy link
Member

necusjz commented May 16, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@necusjz necusjz changed the title Dtzemahweyl/add prive ranges idps [Azure Firewall] az network firewall policy intrusion-detection add: Add new parameter --private-ranges May 16, 2022
@necusjz necusjz merged commit 5ee9a4c into Azure:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants