Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{CI} bump pylint to 2.11.1 #4645

Closed
wants to merge 13 commits into from
Closed

{CI} bump pylint to 2.11.1 #4645

wants to merge 13 commits into from

Conversation

wangzelin007
Copy link
Member

@wangzelin007 wangzelin007 commented Apr 7, 2022 •
edited
Loading

  • Consider use azdev to do static testing. (TODO)
  • Use same pylintrc file and same pylint version 2.11.1.

@ghost ghost added Auto-Assign Auto assign by bot CI labels Apr 7, 2022
@ghost ghost requested review from yonzhan, jiasli and kairu-ms April 7, 2022 05:28
@ghost ghost assigned wangzelin007 Apr 7, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 7, 2022
@jiasli jiasli mentioned this pull request Apr 7, 2022
Merged
@wangzelin007 wangzelin007 changed the title {CI} bump pylint to 2.13.5 {CI} bump pylint to 2.11.1 Apr 7, 2022
@jiasli
Copy link
Member

jiasli commented Apr 7, 2022

Perhaps we can keep in sync with azdev for now which uses pylint==2.11.1: https://github.com/Azure/azure-cli-dev-tools/blob/4f97af4466e70496b810c811cc094729dabe2a0a/setup.py#L72

Better yet, maybe we can use azdev directly!

@wangzelin007 wangzelin007 mentioned this pull request Aug 9, 2022
Merged
@wangzelin007
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangzelin007 wangzelin007 marked this pull request as ready for review February 8, 2023 03:04
@wangzelin007
Copy link
Member Author

Close this PR because @bebound will upgrade pylint to 2.16.1 in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonzhan yonzhan Awaiting requested review from yonzhan

@jiasli jiasli Awaiting requested review from jiasli

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

Assignees

@wangzelin007 wangzelin007

Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Milestone
Dec 2022 (2023-01-10)
Development

Successfully merging this pull request may close these issues.
3 participants
@wangzelin007 @jiasli @yonzhan