Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{image-gallery} az sig create: Update --eula description #4605

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

Jing-song
Copy link
Contributor

@Jing-song Jing-song commented Mar 31, 2022


update description of eula when creating a community gallery Azure/azure-cli#21815
update SDK

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@Jing-song Jing-song requested a review from zhoxing-ms as a code owner March 31, 2022 09:57
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 31, 2022

image-gallery

@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangzelin007
Copy link
Member

@PARADISSEEKR,
Please rerun and re-record these failed tests.

@Jing-song Jing-song marked this pull request as draft April 14, 2022 12:33
@Jing-song Jing-song marked this pull request as ready for review April 19, 2022 05:41
@zhoxing-ms zhoxing-ms merged commit a6a3f1f into Azure:main Apr 19, 2022
@Jing-song Jing-song deleted the jins-eula branch July 19, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants