Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quantum] Expand help and error messages about Provider/SKU format #4603

Merged
merged 3 commits into from
Apr 20, 2022
Merged

[Quantum] Expand help and error messages about Provider/SKU format #4603

merged 3 commits into from
Apr 20, 2022

Conversation

warren-jones
Copy link
Contributor

@warren-jones warren-jones commented Mar 30, 2022 •
edited
Loading

Description of changes:

  • Expanded the error message that’s issued when the -r parameter is missing in az quantum create workspace
  • Added an example of how to find Provider IDs and SKUs in workspace.py and help.py
  • Added more details to the --provider-sku-list -r parameter help in params.py
  • Modified transform_offerings in commands.py for consistency of column headings

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

@ghost ghost added the Auto-Assign Auto assign by bot label Mar 30, 2022
@ghost ghost requested review from kairu-ms and necusjz March 30, 2022 22:15
@ghost ghost assigned kairu-ms Mar 30, 2022
@ghost ghost added this to the Mar 2022 (2022-04-06) milestone Mar 30, 2022
@ghost ghost requested a review from yonzhan March 30, 2022 22:15
@ghost ghost added the Quantum az quantum label Mar 30, 2022
@ghost ghost requested a review from wangzelin007 March 30, 2022 22:15
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 30, 2022

Quantum

@warren-jones warren-jones changed the title [Quantum][DRAFT -- Do not merge] Expand help and error messages about Provider/SKU format [Quantum]Expand help and error messages about Provider/SKU format Apr 11, 2022
@warren-jones warren-jones marked this pull request as ready for review April 11, 2022 21:12
@warren-jones warren-jones changed the title [Quantum]Expand help and error messages about Provider/SKU format [Quantum] Expand help and error messages about Provider/SKU format Apr 13, 2022
@necusjz necusjz merged commit d7d42fc into Azure:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vxfield vxfield vxfield approved these changes

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@necusjz necusjz necusjz approved these changes

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@kairu-ms kairu-ms

Labels
Auto-Assign Auto assign by bot Quantum az quantum
Projects
None yet
Milestone
Apr 2022 (2022-04-26)
Development

Successfully merging this pull request may close these issues.
6 participants
@warren-jones @yonzhan @necusjz @wangzelin007 @vxfield @kairu-ms