Added distro selection feature #4486

imabedalghafer · 2022-03-03T10:54:25Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

[ x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x ] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

[x ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

…into main

ghost · 2022-03-03T10:54:30Z

Thank you for your contribution imabedalghafer! We will review the pull request and get back to you soon.

ghost · 2022-03-03T10:54:37Z

All CLA requirements met.

yonzhan · 2022-03-03T11:21:10Z

VM repair

imabedalghafer · 2022-03-23T07:24:13Z

@zhoxing-ms , Would you please let us know the update for the review of this PR ?

src/vm-repair/azext_vm_repair/_help.py

src/vm-repair/azext_vm_repair/repair_utils.py

imabedalghafer · 2022-03-23T15:00:34Z

@zhoxing-ms The notes have been updated, please let me know if other further updates needed.

Thank you :)

zhoxing-ms · 2022-03-24T02:26:29Z

@imabedalghafer Could you please resolve those CI issues?

wangzelin007 · 2022-03-31T02:57:10Z

@imabedalghafer Could you please resolve those CI issues?

/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:471:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:471:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:472:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:472:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:473:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:473:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:474:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:474:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:475:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:475:13: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:476:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:476:13: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:494:16: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:495:16: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:496:16: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:497:19: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:498:19: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:499:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:500:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:501:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:502:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:503:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:504:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:505:17: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:506:17: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:507:9: E123 closing bracket does not match indentation of opening bracket's line
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:602:9: F402 import 'log' from line 6 shadowed by loop variable
13    E122 continuation line missing indentation or outdented
1     E123 closing bracket does not match indentation of opening bracket's line
1     E128 continuation line under-indented for visual indent
26    E231 missing whitespace after ':'
1     F402 import 'log' from line 6 shadowed by loop variable

imabedalghafer · 2022-03-31T06:42:19Z

@imabedalghafer Could you please resolve those CI issues?

/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:471:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:471:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:472:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:472:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:473:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:473:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:474:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:474:14: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:475:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:475:13: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:476:5: E122 continuation line missing indentation or outdented
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:476:13: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:494:16: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:495:16: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:496:16: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:497:19: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:498:19: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:499:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:500:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:501:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:502:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:503:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:504:18: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:505:17: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:506:17: E231 missing whitespace after ':'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:507:9: E123 closing bracket does not match indentation of opening bracket's line
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:602:9: F402 import 'log' from line 6 shadowed by loop variable
13    E122 continuation line missing indentation or outdented
1     E123 closing bracket does not match indentation of opening bracket's line
1     E128 continuation line under-indented for visual indent
26    E231 missing whitespace after ':'
1     F402 import 'log' from line 6 shadowed by loop variable

Apologies for the delay , sure I will work on them

imabedalghafer · 2022-04-01T07:55:25Z

@wangzelin007, I have resolved the above CLI errors. would you please check

imabedalghafer · 2022-04-06T08:03:01Z

@wangzelin007 Any update please ?

wangzelin007 · 2022-04-06T08:51:34Z

@wangzelin007 Any update please ?

Sorry for the late reply, I will merge this PR ASAP.

wangzelin007 · 2022-04-06T10:03:08Z

/azp run

azure-pipelines · 2022-04-06T10:03:17Z

Azure Pipelines successfully started running 1 pipeline(s).

wangzelin007 · 2022-04-06T10:23:30Z

@wangzelin007 Any update please ?

Hi imabedalghafer,

May I ask whether it is necessary to add a scenario test for this new argument ?
And if you want to release the new extension version, please write the description of changes into HISTORY.rst and update setup.py.

imabedalghafer · 2022-04-06T10:47:02Z

@wangzelin007 Thank you for the update.
let me check internally on that part and will get back to you

…into main

imabedalghafer · 2022-04-19T07:38:57Z

@wangzelin007
Apologies for the delay
The test units, history and setup files are updated

Thank you and much appreciate your help

imabedalghafer and others added 9 commits September 5, 2021 15:25

add distro option

9590d74

added distro option to select the distro for recovery VM

fc45502

adding gen2 support

462a5c8

updated the support for gen2 machines

e2911b1

updating the unlock script to match different distros

41c3380

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

9ad66b1

…into main

updating the fork from main branch and adding the feature

fc27494

Adding missing comma

c1339a7

fixing the style

cffbce4

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 3, 2022

yonzhan requested review from zhoxing-ms and wangzelin007 March 3, 2022 11:21

yonzhan assigned zhoxing-ms Mar 3, 2022

yonzhan added this to the Mar 2022 (2022-04-05) milestone Mar 3, 2022

Merge remote-tracking branch 'upstream/main' into main

4336f02

zhoxing-ms reviewed Mar 23, 2022

View reviewed changes

src/vm-repair/azext_vm_repair/_help.py Outdated Show resolved Hide resolved

zhoxing-ms reviewed Mar 23, 2022

View reviewed changes

src/vm-repair/azext_vm_repair/repair_utils.py Outdated Show resolved Hide resolved

zhoxing-ms reviewed Mar 23, 2022

View reviewed changes

src/vm-repair/azext_vm_repair/repair_utils.py Outdated Show resolved Hide resolved

imabedalghafer added 2 commits March 23, 2022 14:06

updated the help text

14318ff

updated the image selector function and the telementry key

8c29cbb

updating the styling errors

0ab3fe1

yonzhan removed this from the Mar 2022 (2022-04-06) milestone Apr 1, 2022

yonzhan added this to the Apr 2022 (2022-04-26) milestone Apr 1, 2022

wangzelin007 mentioned this pull request Apr 6, 2022

{CI} Fix tests not belonging to the changed extension are running #4637

Merged

imabedalghafer added 3 commits April 19, 2022 07:29

Updated the history, version and test units

c5647be

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

7980798

…into main

updated the history and setup file

dfd7755

wangzelin007 approved these changes Apr 20, 2022

View reviewed changes

zhoxing-ms approved these changes Apr 20, 2022

View reviewed changes

zhoxing-ms merged commit 044de57 into Azure:main Apr 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added distro selection feature #4486

Added distro selection feature #4486

imabedalghafer commented Mar 3, 2022

ghost commented Mar 3, 2022

ghost commented Mar 3, 2022 •

edited by ghost

Loading

yonzhan commented Mar 3, 2022

imabedalghafer commented Mar 23, 2022

imabedalghafer commented Mar 23, 2022

zhoxing-ms commented Mar 24, 2022

wangzelin007 commented Mar 31, 2022

imabedalghafer commented Mar 31, 2022

imabedalghafer commented Apr 1, 2022

imabedalghafer commented Apr 6, 2022

wangzelin007 commented Apr 6, 2022

wangzelin007 commented Apr 6, 2022

azure-pipelines bot commented Apr 6, 2022

wangzelin007 commented Apr 6, 2022 •

edited

Loading

imabedalghafer commented Apr 6, 2022

imabedalghafer commented Apr 19, 2022

Added distro selection feature #4486

Added distro selection feature #4486

Conversation

imabedalghafer commented Mar 3, 2022

General Guidelines

About Extension Publish

ghost commented Mar 3, 2022

ghost commented Mar 3, 2022 • edited by ghost Loading

yonzhan commented Mar 3, 2022

imabedalghafer commented Mar 23, 2022

imabedalghafer commented Mar 23, 2022

zhoxing-ms commented Mar 24, 2022

wangzelin007 commented Mar 31, 2022

imabedalghafer commented Mar 31, 2022

imabedalghafer commented Apr 1, 2022

imabedalghafer commented Apr 6, 2022

wangzelin007 commented Apr 6, 2022

wangzelin007 commented Apr 6, 2022

azure-pipelines bot commented Apr 6, 2022

wangzelin007 commented Apr 6, 2022 • edited Loading

imabedalghafer commented Apr 6, 2022

imabedalghafer commented Apr 19, 2022

ghost commented Mar 3, 2022 •

edited by ghost

Loading

wangzelin007 commented Apr 6, 2022 •

edited

Loading