[Spring Cloud] Add application configuration service related implementation #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spring Cloud |
zhoxing-ms
reviewed
Dec 29, 2021
| acs_resource = _get_or_default_acs_resource(client, resource_group, service) | ||
| repos = acs_resource.properties.settings.git_property.repositories | ||
| if next((r for r in repos if r.name == name), None) is not None: | ||
| raise CLIError("Repo '{}' already exists.".format(name)) |
There was a problem hiding this comment.
Please use the specific error type ValidationError instead of CLIError.
zhoxing-ms
reviewed
Dec 29, 2021
| acs_settings = acs_resource.properties.settings | ||
|
|
||
| if not acs_settings or not acs_settings.git_property or not acs_settings.git_property.repositories: | ||
| raise CLIError("Repos not found.") |
There was a problem hiding this comment.
Please use the specific error type ResourceNotFoundError instead of CLIError.
There was a problem hiding this comment.
Updated, thanks for suggestion.
zhoxing-ms
reviewed
Dec 29, 2021
| def _get_existing_repo(repos, name): | ||
| repo = next((r for r in repos if r.name == name), None) | ||
| if not repo: | ||
| raise CLIError("Repo '{}' not found.".format(name)) |
zhoxing-ms
reviewed
Dec 29, 2021
| try: | ||
| result = sdk_no_wait(False, client.configuration_services.begin_validate, resource_group, service, DEFAULT_NAME, acs_settings).result() | ||
| except Exception as err: # pylint: disable=broad-except | ||
| raise CLIError("{0}. You may raise a support ticket if needed by the following link: https://docs.microsoft.com/azure/spring-cloud/spring-cloud-faq?pivots=programming-language-java#how-can-i-provide-feedback-and-report-issues".format(err)) |
zhoxing-ms
reviewed
Dec 29, 2021
| if not git_result.is_valid: | ||
| validation_result = git_result.git_repos_validation_result | ||
| filter_result = [{'name': x.name, 'messages': x.messages} for x in validation_result if len(x.messages) > 0] | ||
| raise CLIError("Application Configuration Service settings contain errors.\n{}".format(json.dumps(filter_result, indent=2))) |
wangzelin007
approved these changes
Dec 29, 2021
zhoxing-ms
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr is part of main...VSChina:enterprise.
Add implementation of Application Configuration Service show, clear, git add, git update, git remove, git list, bind and unbind.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.