[Spring Cloud] Add gateway related methods #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninpan-ms
changed the title
|
Spring Cloud |
zhoxing-ms
reviewed
Dec 28, 2021
| route_configs = client.gateway_route_configs.list( | ||
| resource_group, service, DEFAULT_NAME) | ||
| if name in (route_config.name for route_config in list(route_configs)): | ||
| raise CLIError("Route config " + name + " already exists") |
There was a problem hiding this comment.
Could we use the specific error type InvalidArgumentValueError or ValidationError instead of CLIError?
There was a problem hiding this comment.
Updated and added description
|
Is this part of main...VSChina:enterprise ? If so, please link these relevant PRs in the PR description |
Co-authored-by: ZelinWang <[email protected]>
Co-authored-by: ZelinWang <[email protected]>
zhoxing-ms
approved these changes
Dec 29, 2021
wangzelin007
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of gateway update, show, clear, gateway custom-domain show, list, update, unbind, gateway route-config show, list, create, update and remove.
The pr is part of main...VSChina:enterprise.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.