Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spring-cloud] Add validator for app deploy and app deployment create #4258

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Dec 27, 2021


Description

This PR add validator on given arguments for az spring-cloud app deploy and az spring-cloud app deployment create.

  • --source-path, --artifact-path and --container-image must be provided one and only one.
  • --cpu and --memory must be provided in accepted type, here put the normalize to the parameter parsing

This PR doesn't prompt version on purpose, will do it together with other PRs

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yuwzho yuwzho closed this Dec 27, 2021
@yuwzho yuwzho reopened this Dec 27, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 27, 2021

spring-cloud

@jsntcy
Copy link
Member

jsntcy commented Dec 27, 2021

/check-enforcer evaluate

@jsntcy
Copy link
Member

jsntcy commented Dec 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 5fa9c47 into Azure:main Dec 28, 2021
@yuwzho yuwzho mentioned this pull request Jan 5, 2022
3 tasks
@yuwzho
Copy link
Contributor Author

yuwzho commented Jan 5, 2022

#4294

@yuwzho yuwzho deleted the yuwzho/add_validator branch May 18, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants