-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{spring-cloud} Add spring-cloud create --sku Enterprise
#4252
{spring-cloud} Add spring-cloud create --sku Enterprise
#4252
Conversation
spring-cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write the description of changes into HISTORY.rst and update setup.py to release the new extension version.
No, we will announce the public preview on Jan. 17th, for the public preview, we have a lot of new features contributed to CLI. Will update the release notes and version together after all changes merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spring-cloud create --sku Enterprise
Description
This PR adds
az spring-cloud create --sku Enterprise
choice. Since whensku=Enterprise
, the creation steps are very different with others (later PR will introduce some other parameters which can be used in Enterprise only), this PR adds a router beforecustom.py
for create command, routing the command whosesku==Enterprise
to another impl file. In the new impl file, there will be some steps like creating the top level resource, later creation nested resource for enterprise only. All tiers shares the same step to create top level resource, the new impl file invokes the top level resource creation impl fromcustom.py
as well.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.