Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{spring-cloud} Add spring-cloud create --sku Enterprise #4252

Merged

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Dec 22, 2021


Description

This PR adds az spring-cloud create --sku Enterprise choice. Since when sku=Enterprise, the creation steps are very different with others (later PR will introduce some other parameters which can be used in Enterprise only), this PR adds a router before custom.py for create command, routing the command whose sku==Enterprise to another impl file. In the new impl file, there will be some steps like creating the top level resource, later creation nested resource for enterprise only. All tiers shares the same step to create top level resource, the new impl file invokes the top level resource creation impl from custom.py as well.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 22, 2021

spring-cloud

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the description of changes into HISTORY.rst and update setup.py to release the new extension version.

@yuwzho
Copy link
Contributor Author

yuwzho commented Dec 23, 2021

Please write the description of changes into HISTORY.rst and update setup.py to release the new extension version.

No, we will announce the public preview on Jan. 17th, for the public preview, we have a lot of new features contributed to CLI. Will update the release notes and version together after all changes merged.

@yuwzho yuwzho requested a review from wangzelin007 December 23, 2021 05:15
Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzelin007 wangzelin007 changed the title add spring-cloud create --sku Enterprise {spring-cloud} Add spring-cloud create --sku Enterprise Dec 23, 2021
@wangzelin007 wangzelin007 merged commit 56a983b into Azure:main Dec 23, 2021
@yuwzho yuwzho deleted the yuwzho/spring-cloud-create-enterprise branch December 23, 2021 07:52
@yuwzho yuwzho mentioned this pull request Jan 5, 2022
3 tasks
@yuwzho
Copy link
Contributor Author

yuwzho commented Jan 5, 2022

#4294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants