Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 Move ensure_active_deployment_exist to validator #4192

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Dec 6, 2021

There are some commands request there is an active Deployment under the App. This PR moves the logic from every commands to a validator
It doesn't increase the CLI extension version on purpose


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

There are some commands request there is an active Deployment under the
App. This PR moves the logic from every commands to a validator
@yuwzho yuwzho force-pushed the yuwzho/ensure-active-deployment-exist branch from 1c54f09 to 06f6fca Compare December 6, 2021 07:14
@jiasli jiasli assigned zhoxing-ms and xingong202 and unassigned xingong202 Dec 8, 2021
@jiasli
Copy link
Member

jiasli commented Dec 8, 2021

spring-cloud

@zhoxing-ms zhoxing-ms merged commit 8f9d065 into Azure:main Dec 8, 2021
@yuwzho yuwzho deleted the yuwzho/ensure-active-deployment-exist branch December 9, 2021 05:50
@yuwzho yuwzho mentioned this pull request Jan 5, 2022
3 tasks
@yuwzho
Copy link
Contributor Author

yuwzho commented Jan 5, 2022

#4294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants