-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS][aks-preview] az aks nodepool upgrade
: Add new parameter --aks-custom-headers
#3658
Merged
zhoxing-ms
merged 6 commits into
Azure:main
from
mainred:support-http-header-for-aks-nodepool-upgrade
Jul 22, 2021
Merged
[AKS][aks-preview] az aks nodepool upgrade
: Add new parameter --aks-custom-headers
#3658
zhoxing-ms
merged 6 commits into
Azure:main
from
mainred:support-http-header-for-aks-nodepool-upgrade
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainred
requested review from
andyliuliming,
gtracer and
zqingqing1
as code owners
July 15, 2021 08:45
aks |
feiskyer
approved these changes
Jul 19, 2021
mainred
changed the title
Add
[AKS][aks-preview] Add Jul 19, 2021
--aks-custom-headers
for az aks nodepool upgrade
--aks-custom-headers
for az aks nodepool upgrade
@zhoxing-ms , could you please take a look? Thanks. |
zhoxing-ms
changed the title
[AKS][aks-preview] Add
[AKS][aks-preview] Jul 19, 2021
--aks-custom-headers
for az aks nodepool upgrade
az aks nodepool upgrade
: Add new parameter --aks-custom-headers
AbelHu
approved these changes
Jul 19, 2021
@mainred Could you add some test cases for this new parameter? |
mainred
commented
Jul 19, 2021
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
mainred
force-pushed
the
support-http-header-for-aks-nodepool-upgrade
branch
3 times, most recently
from
July 20, 2021 03:15
10a8133
to
decbf80
Compare
mainred
force-pushed
the
support-http-header-for-aks-nodepool-upgrade
branch
from
July 20, 2021 07:54
b852f87
to
77a644f
Compare
FumingZhang
requested changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add a space to separate options
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
FumingZhang
approved these changes
Jul 21, 2021
zhoxing-ms
reviewed
Jul 21, 2021
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.set the env and add new test
azdev setup --cli /home/azureuser/go/src/github.com/Azure/azure-cli --repo /home/azureuser/go/src/github.com/Azure/azure-cli-extensions
reference: https://github.com/Azure/azure-cli-dev-tools#style-linter-check-and-testing
azdev test aks-preview
test with the self-built aks-preview
azdev extension publish aks-preview --storage-account $STORAGEACCOUNT --storage-subscription $STORAGESUB --storage-container azure-cli-extension --update-index
az extension add --source $python-wheel-blob-url
az aks nodepool upgrade --resource-group $rg --cluster-name k8s --name dr2 --kubernetes-version 1.21.1 --aks-custom-headers WindowsContainerRuntime=containerd --debug
returns successfully and the header value can ben seen below: