-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{diskpool} Refine output and add new command #3490
Conversation
diskpool |
@@ -98,6 +98,16 @@ | |||
az disk-pool delete --name "myDiskPool" --resource-group "myResourceGroup" | |||
""" | |||
|
|||
helps['disk-pool list-outbound-network-dependency-endpoint'] = """ | |||
type: command | |||
short-summary: "Gets the network endpoints of all outbound dependencies of a Disk Pool." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short-summary: "Gets the network endpoints of all outbound dependencies of a Disk Pool." | |
short-summary: Get the network endpoints of all outbound dependencies of a Disk Pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is generated code
('Availability Zones', 'availabilityZones'), | ||
('Resource Group', 'resourceGroup'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why do we need to modify those value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as service request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.