[Front Door] Add update func for backend and fix backend_host_header #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…judgment in create func
kairu-ms
reviewed
May 19, 2021
|
Front Door |
kairu-ms
reviewed
Jun 2, 2021
kairu-ms
reviewed
Jun 2, 2021
kairu-ms
reviewed
Jun 2, 2021
kairu-ms
reviewed
Jun 2, 2021
kairu-ms
requested changes
Jun 2, 2021
kairu-ms
reviewed
Jun 15, 2021
| c.update_param('private_link_location', private_link_location, None) | ||
| c.update_param('private_link_approval_message', private_link_approval_message, None) | ||
| client.begin_create_or_update(resource_group_name, front_door_name, frontdoor).result() | ||
| return backend |
There was a problem hiding this comment.
Why the return value is not from request result?
There was a problem hiding this comment.
Based on add_fd_backend, backend is a part of frontdoor, we just need return backend, not all result from frontdoor.
There was a problem hiding this comment.
I think we should extract the backend from the result again instead of returning the backend object used in request construction. Because the backend in result may be not the same as the backend in request. For example, some read only property may be changed in result.
kairu-ms
approved these changes
Jul 1, 2021
|
Please update extension version and history before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed Azure/azure-cli#17270
Closed Azure/azure-cli#17269
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.