Remove Oracle To Pg scenario support #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't make changes to the vendored_sdk folder - this folder contains generated file from autorest. |
|
Make changes to the _help.py to update the documentations for the commands. |
|
Make sure to update the version of the extension. See previous PRs on how to do that. |
|
Refer to this page on how to build your changes to be tested locally. |
temandr
changed the title
temandr
approved these changes
May 1, 2021
|
@jsntcy to help with |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@sumitdvlp, @temandr, please rebase on |
jsntcy
approved these changes
May 25, 2021
kairu-ms
reviewed
Aug 5, 2021
| @@ -3,28 +3,27 @@ | |||
| # Licensed under the MIT License. See License.txt in the project root for license information. | |||
| # -------------------------------------------------------------------------------------------- | |||
|
|
|||
| from azure.cli.command_modules.dms.commands import dms_api_exception_handler | |||
There was a problem hiding this comment.
dms_api_exception_handler does not exist in azure-cli repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove Oracle to PG scenario, part of the process is to remove the support to upload OCI driver using the extension and all modules related to Oracle to PG scenario.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.