aks: vendor 20201201 sdk and add 'enable-encryption-at-host' parameter #2912
Conversation
|
hi @andyzhangx the change looks good. Pls run live test to make sure no regression caused by API version bump. thanks. |
andyzhangx
changed the title
andyzhangx
changed the title
fix recording test failures change aks default version to 20201201 fix test failures fix test case fix image names
aks: add history aks: fix go linter aks: fix linter
@yungezz I have run the live tests and also fixed the test case issues, PTAL again, hanks. |
|
@yungezz could you merge this PR? thanks. |
| @@ -123,6 +123,7 @@ def load_arguments(self, _): | |||
| c.argument('appgw_subnet_id', options_list=['--appgw-subnet-id'], arg_group='Application Gateway') | |||
| c.argument('appgw_watch_namespace', options_list=['--appgw-watch-namespace'], arg_group='Application Gateway') | |||
| c.argument('aci_subnet_name', type=str) | |||
| c.argument('enable_encryption_at_host', options_list=['--enable-encryption-at-host'], action='store_true') | |||
There was a problem hiding this comment.
Is this a property that will be persisted in resource? If so, then get_three_state_flag() is recommended instead of using action='store_true'
There was a problem hiding this comment.
hi @fengzhou-msft the property is a bool type which is persisted in resource.
what's the diff between store_true and get_three_state_flag? I found all AKS code are using store_true:
c.argument('enable_cluster_autoscaler', options_list=["--enable-cluster-autoscaler", "-e"], action='store_true')
c.argument('disable_cluster_autoscaler', options_list=["--disable-cluster-autoscaler", "-d"], action='store_true')
c.argument('update_cluster_autoscaler', options_list=["--update-cluster-autoscaler", "-u"], action='store_true')
Do you mean I should change to following? Thanks.
c.argument('enable_encryption_at_host', arg_type=get_three_state_flag(), help='Enable EncryptionAtHost.'
|
hi @fengzhou-msft is this PR ready to merge? thanks |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.