[Automation] Adding command linting for extensions to ensure consistency. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troydai
changed the title
fail on error static check
troydai
suggested changes
Sep 5, 2018
|
|
||
| # Install CLI & Dev Tools | ||
| echo "Installing azure-cli-dev-tools and azure-cli..." | ||
| pip install --pre azure-cli --extra-index-url https://azurecliprod.blob.core.windows.net/edge |
There was a problem hiding this comment.
Print the az version so that we can check if the az is the latest build from the log.
scripts/ci/verify_linter.sh
Outdated
| set +x # json output is too verbose | ||
| public_index=$(az extension list-available -d) | ||
| index_file=$(cat ./src/index.json) | ||
| modified_extensions=$(python ./scripts/ci/index_changes.py "$index_file" "$public_index") |
There was a problem hiding this comment.
Ugr, the three lines of code look ugly. Is there a better way?
There was a problem hiding this comment.
I'll put this part of the code all into the python script
do get() in case of new entry
troydai
approved these changes
Sep 5, 2018
ShreyaAnand
pushed a commit
to ShreyaAnand/azure-cli-extensions
that referenced
this pull request
Dec 31, 2024
Upload model for `az monitor private-link-scope`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #205
-Linter verification occurs whenever index for a extension is modified, therefore publishing a new version of the extension.
-Teams will be expected to address linter problems with their extension when they next publish.