[Connectedk8s] Kubernetes distro and infra parameter and heuristics support #2620

alphaWizard · 2020-11-04T10:40:34Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

…into distro-infra-feature

azuresdkci · 2020-11-04T10:40:49Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it mcr.microsoft.com/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/alphaWizard/azure-cli-extensions.git@distro-infra-feature#subdirectory=src/$EXT&egg=$EXT"

alphaWizard · 2020-11-05T09:46:31Z

src/connectedk8s/azext_connectedk8s/_params.py

 from azure.cli.core.commands.parameters import (file_type)
 from azure.cli.core.commands.validators import get_default_location_from_resource_group

+distribution_types = ["auto", "generic", "openshift", "rancher_RKE", "kind", "GKE", "EKS", "AKS", "AKS-HCI", "CAPZ", "AKS-engine", "TKG"]
+infrastructure_types = ["auto", "generic", "azure", "AWS", "GCP", "Azure_Stack_HC", "Azure_Stack_Hub", "Azure_Stack_Edge", "vSphere"]
+


"auto" is default cli value, which triggers heuristics evaluation, Remaining are the enum values.

shashankbarsin · 2020-11-05T09:50:35Z

src/connectedk8s/azext_connectedk8s/_constants.py

@@ -6,6 +6,8 @@

 # pylint: disable=line-too-long

+infrastructure_types = ["generic", "azure", "AWS", "GCP", "Azure_Stack_HC", "Azure_Stack_Hub", "Azure_Stack_Edge", "vSphere"]


Use following values:

generic

Amazon Web Services

Google Cloud Platform

Microsoft Azure

Azure Stack Edge

Azure Stack Hub

Azure Stack HCI

VMware vSphere

vSphere I'll check if we can differentiate between 6.x and 7.x by heuristics

shashankbarsin · 2020-11-05T09:51:27Z

src/connectedk8s/azext_connectedk8s/_params.py

 from azure.cli.core.commands.parameters import (file_type)
 from azure.cli.core.commands.validators import get_default_location_from_resource_group

+distribution_types = ["auto", "generic", "openshift", "rancher_RKE", "kind", "GKE", "EKS", "AKS", "AKS-HCI", "CAPZ", "AKS-engine", "TKG"]
+infrastructure_types = ["auto", "generic", "azure", "AWS", "GCP", "Azure_Stack_HC", "Azure_Stack_Hub", "Azure_Stack_Edge", "vSphere"]


Use following values:

generic

Amazon Web Services

Google Cloud Platform

Microsoft Azure

Azure Stack Edge

Azure Stack Hub

Azure Stack HCI

VMware vSphere

One doubt, so if user is providing these values, he will have to type whole like "AmazonWebServices". Isn't it easy for user for type just --infrastructure AWS?. We can always add a logic wherever we want to display(like in portal) to transform from AWS to Amazon Web Services.

shashankbarsin · 2020-11-05T10:00:44Z

src/connectedk8s/azext_connectedk8s/_params.py

 from azure.cli.core.commands.parameters import (file_type)
 from azure.cli.core.commands.validators import get_default_location_from_resource_group

+distribution_types = ["auto", "generic", "openshift", "rancher_RKE", "kind", "GKE", "EKS", "AKS", "AKS-HCI", "CAPZ", "AKS-engine", "TKG"]


Use following values:

Azure Kubernetes Service

Google Kubernetes Engine

Amazon Elastic Kubernetes Service

Rancher Kubernetes Engine

OpenShift Kubernetes Distribution

OpenShift Container Platform

K3s

kind

minikube

Cluster API Provider Azure

AKS Engine

Tanzu Kubernetes Grid

Canonical Charmed Kubernetes

We should check if we can distinguish between OKD and OCP in above list.

We should also check if Docker for Mac/Windows has any cluster identifying characteristic in which case we can include that in the list as well

yonzhan · 2020-11-05T11:14:49Z

Connectedk8s

…into distro-infra-feature

…/azure-cli-extensions into distro-infra-feature

src/connectedk8s/azext_connectedk8s/vendored_sdks/operations/connected_cluster_operations.py

src/connectedk8s/azext_connectedk8s/_params.py

src/connectedk8s/azext_connectedk8s/custom.py

src/connectedk8s/setup.py

alphaWizard · 2020-12-07T17:27:02Z

@fengzhou-msft Review is done from the connectedk8s side. It is ready for checking in if you don't have any further reviews.

alphaWizard · 2020-12-08T11:51:43Z

@fengzhou-msft Review is done from the connectedk8s side. It is ready for checking in if you don't have any further reviews.

@fengzhou-msft Gentle ping regarding this.

Arpit Gupta added 7 commits October 30, 2020 19:52

initial commit

c2ee639

Updated helm install

d613f41

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

2875ce9

…into distro-infra-feature

Fixed

494322d

cleaned up

7728b56

Updated version

725cb8c

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

6598d1a

…into distro-infra-feature

Fixed linting

8600297

yungezz requested a review from akashkeshari November 5, 2020 03:22

yungezz assigned fengzhou-msft Nov 5, 2020

yungezz added the Connected Kubernetes label Nov 5, 2020

Azure deleted a comment from yonzhan Nov 5, 2020

Added gke distro heuristics

f81d693

alphaWizard commented Nov 5, 2020

View reviewed changes

shashankbarsin reviewed Nov 5, 2020

View reviewed changes

alphaWizard and others added 10 commits November 6, 2020 17:46

added eks,aws

145b59e

Updated enum names and verified heuristics

51c17ee

Fixed conflict

01f9fa4

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

8db81f2

…into distro-infra-feature

added new sdk

903b1c9

Revert

1cf82cc

Added new sdk

64230e8

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

ef6353b

…into distro-infra-feature

Fix

49af79f

updated sdk

3a0753b

alphaWizard marked this pull request as ready for review November 27, 2020 06:01

alphaWizard and others added 6 commits November 27, 2020 12:07

Delete code-model-v1

f5cd767

Update _params.py

5895783

Removed debug logs

95e2d07

Merge branch 'distro-infra-feature' of https://github.com/alphaWizard…

aaebb2e

…/azure-cli-extensions into distro-infra-feature

Fixed linting

9d9ade0

Added rancher_rke distro

6b9a43e

akashkeshari reviewed Dec 2, 2020

View reviewed changes

src/connectedk8s/azext_connectedk8s/vendored_sdks/operations/connected_cluster_operations.py Show resolved Hide resolved

akashkeshari reviewed Dec 2, 2020

View reviewed changes

src/connectedk8s/azext_connectedk8s/_params.py Outdated Show resolved Hide resolved

akashkeshari reviewed Dec 2, 2020

View reviewed changes

src/connectedk8s/azext_connectedk8s/custom.py Show resolved Hide resolved

Arpit Gupta and others added 7 commits December 2, 2020 13:45

Incorporating comments

cb86a2c

Fix conflict

2af3c0f

Fix conflict

c4825bc

Updated distro/infra telemetry via get in update_agents

31fe354

Fix version

11141b7

Merge

a5519b5

Merge branch 'master' into distro-infra-feature

cac3a8d

akashkeshari approved these changes Dec 7, 2020

View reviewed changes

Anumita suggested changes Dec 7, 2020

View reviewed changes

src/connectedk8s/setup.py Outdated Show resolved Hide resolved

reverted back to 0.2.7

a65b10f

Anumita approved these changes Dec 7, 2020

View reviewed changes

fengzhou-msft approved these changes Dec 9, 2020

View reviewed changes

fengzhou-msft merged commit 672e8c0 into Azure:master Dec 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Connectedk8s] Kubernetes distro and infra parameter and heuristics support #2620

[Connectedk8s] Kubernetes distro and infra parameter and heuristics support #2620

alphaWizard commented Nov 4, 2020

azuresdkci commented Nov 4, 2020

alphaWizard Nov 5, 2020 •

edited

Loading

shashankbarsin Nov 5, 2020 •

edited

Loading

shashankbarsin Nov 5, 2020

shashankbarsin Nov 5, 2020 •

edited

Loading

alphaWizard Nov 5, 2020 •

edited

Loading

shashankbarsin Nov 5, 2020

shashankbarsin Nov 5, 2020

shashankbarsin Nov 5, 2020

yonzhan commented Nov 5, 2020

alphaWizard commented Dec 7, 2020

alphaWizard commented Dec 8, 2020

		@@ -6,6 +6,8 @@

		# pylint: disable=line-too-long

		infrastructure_types = ["generic", "azure", "AWS", "GCP", "Azure_Stack_HC", "Azure_Stack_Hub", "Azure_Stack_Edge", "vSphere"]

[Connectedk8s] Kubernetes distro and infra parameter and heuristics support #2620

[Connectedk8s] Kubernetes distro and infra parameter and heuristics support #2620

Conversation

alphaWizard commented Nov 4, 2020

General Guidelines

About Extension Publish

azuresdkci commented Nov 4, 2020

alphaWizard Nov 5, 2020 • edited Loading

Choose a reason for hiding this comment

shashankbarsin Nov 5, 2020 • edited Loading

Choose a reason for hiding this comment

shashankbarsin Nov 5, 2020

Choose a reason for hiding this comment

shashankbarsin Nov 5, 2020 • edited Loading

Choose a reason for hiding this comment

alphaWizard Nov 5, 2020 • edited Loading

Choose a reason for hiding this comment

shashankbarsin Nov 5, 2020

Choose a reason for hiding this comment

shashankbarsin Nov 5, 2020

Choose a reason for hiding this comment

shashankbarsin Nov 5, 2020

Choose a reason for hiding this comment

yonzhan commented Nov 5, 2020

alphaWizard commented Dec 7, 2020

alphaWizard commented Dec 8, 2020

alphaWizard Nov 5, 2020 •

edited

Loading

shashankbarsin Nov 5, 2020 •

edited

Loading

shashankbarsin Nov 5, 2020 •

edited

Loading

alphaWizard Nov 5, 2020 •

edited

Loading