Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connectedmachine extension #2362

Conversation

TylerLeonhardt
Copy link
Member


This updates the connectedmachine extension to 2020-08-02 of the spec. In doing this I also changed the autogenerated tests to test more useful things.

I was told to move the changed tests to the custom folder but after doing that then the test didn't run... so I'm not sure what to do there...

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/TylerLeonhardt/azure-cli-extensions.git@sdkAutomation/connectedmachine#subdirectory=src/$EXT&egg=$EXT"

@TylerLeonhardt
Copy link
Member Author

-  FAIL - HIGH severity: option_length_too_long
    Parameter: connectedmachine machine-extension create, `auto_upgrade_minor_version` - The lengths of all options ['--auto-upgrade-minor-version'] are longer than threshold 22. Argument auto_upgrade_minor_version must have a short abbreviation.
    Parameter: connectedmachine machine-extension update, `auto_upgrade_minor_version` - The lengths of all options ['--auto-upgrade-minor-version'] are longer than threshold 22. Argument auto_upgrade_minor_version must have a short abbreviation.

Is there a way to ignore this? I don't really think it's a parameter that can be shortened.

Also, the Integration Tests don't appear to be connectedmachine's fault so I guess I should ignore those failures?

@yungezz
Copy link
Member

yungezz commented Sep 15, 2020

hi @fengzhou-msft could you pls help to review the PR for Azure Arc for Servers? thanks

@TylerLeonhardt
Copy link
Member Author

This PR should fix the lint issue:
Azure/azure-rest-api-specs#10789

@@ -0,0 +1,183 @@
# Azure CLI Module Creation Report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for? It should be auto-gen code report, no need to checkin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea it was there as a part of the generation

@@ -0,0 +1 @@
# Marker file for PEP 561.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this file used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea it was there as a part of the generation

@@ -0,0 +1,10 @@
|Scenario|Result|ErrorMessage|ErrorStack|ErrorNormalized|StartDt|EndDt|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this no need to be checked in also.

@TylerLeonhardt
Copy link
Member Author

Closing in favor of #2364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PLR PLR work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants