-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update connectedmachine extension #2362
Update connectedmachine extension #2362
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
Is there a way to ignore this? I don't really think it's a parameter that can be shortened. Also, the Integration Tests don't appear to be connectedmachine's fault so I guess I should ignore those failures? |
hi @fengzhou-msft could you pls help to review the PR for Azure Arc for Servers? thanks |
This PR should fix the lint issue: |
@@ -0,0 +1,183 @@ | |||
# Azure CLI Module Creation Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for? It should be auto-gen code report, no need to checkin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea it was there as a part of the generation
@@ -0,0 +1 @@ | |||
# Marker file for PEP 561. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this file used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea it was there as a part of the generation
@@ -0,0 +1,10 @@ | |||
|Scenario|Result|ErrorMessage|ErrorStack|ErrorNormalized|StartDt|EndDt| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this no need to be checked in also.
Closing in favor of #2364 |
This updates the connectedmachine extension to 2020-08-02 of the spec. In doing this I also changed the autogenerated tests to test more useful things.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.