[Account] Add new alias, tenant commands #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
account |
yungezz
reviewed
Sep 8, 2020
| c.argument('display_name', type=str, help='The friendly name of the subscription.') | ||
| c.argument('workload', arg_type=get_enum_type(['Production', 'DevTest']), help='The workload type of the ' | ||
| 'subscription. It can be either Production or DevTest.') | ||
| c.argument('billing_scope', type=str, help='Determines whether subscription is fieldLed, partnerLed or ' |
There was a problem hiding this comment.
why the case isn't consistent? from Swagger directly?
There was a problem hiding this comment.
It's from swagger. I have updated it.
There was a problem hiding this comment.
Thanks Feng. better to feedback to swagger, really confusing. :)
qwordy
reviewed
Sep 8, 2020
qwordy
reviewed
Sep 8, 2020
qwordy
reviewed
Sep 8, 2020
qwordy
reviewed
Sep 8, 2020
| self.cmd('az account subscription cancel --subscription-id {subscription_id} --yes', | ||
| checks=[self.check('subscriptionId', '{subscription_id}')]) | ||
| if self.in_recording: | ||
| time.sleep(300) |
There was a problem hiding this comment.
sleep is mocked. if self.in_recording is not necessary.
Why 300? Is it an asynchronous operation?
There was a problem hiding this comment.
yes. it is asynchronous.
qwordy
approved these changes
Sep 8, 2020
Co-authored-by: Feiyue Yu <[email protected]>
fengzhou-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az account subscription createThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.