Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor] Ask users to consent during APM migration #2254

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

jsntcy
Copy link
Member

@jsntcy jsntcy commented Sep 1, 2020

This is to ask users to consent during APM migration which is described in Azure/azure-cli#14787.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@jsntcy jsntcy requested a review from mmyyrroonn September 1, 2020 03:38
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jsntcy/azure-cli-extensions.git@apm-migration#subdirectory=src/$EXT&egg=$EXT"

@jsntcy jsntcy requested a review from haroldrandom September 1, 2020 03:38
@jsntcy jsntcy self-assigned this Sep 1, 2020
@jsntcy jsntcy added this to the S175 milestone Sep 1, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 1, 2020

Monitor

need_consent = True

if need_consent:
from azure.cli.core.util import user_confirmation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does user have to user terminal to execute this command?

Copy link
Member Author

@jsntcy jsntcy Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need customer to consent, since there is no way to go back to 2.0 from 2.1.

@jsntcy jsntcy merged commit 86f75fa into Azure:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants