Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New preview version for Maintenance extension #2214

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Conversation

sotaneja
Copy link
Contributor

@sotaneja sotaneja commented Aug 21, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/sotaneja/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 21, 2020

Maintenance

@sotaneja
Copy link
Contributor Author

@jsntcy can I get a review please?

src/maintenance/setup.py Outdated Show resolved Hide resolved
@jsntcy
Copy link
Member

jsntcy commented Sep 1, 2020

@sotaneja, could you please update the PR based on the comments above so that we can have another review before merging?

@sotaneja
Copy link
Contributor Author

sotaneja commented Sep 2, 2020

@jsntcy I have made your PR suggestions. Thanks.

Copy link
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsntcy jsntcy merged commit 5a0fd4e into Azure:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants