Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension Swiftlet #2204

Merged
merged 10 commits into from
Aug 24, 2020
Merged

New extension Swiftlet #2204

merged 10 commits into from
Aug 24, 2020

Conversation

qwordy
Copy link
Member

@qwordy qwordy commented Aug 19, 2020

Resolve Azure/azure-cli#14418


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/qwordy/azure-cli-extensions.git@swiftlet#subdirectory=src/$EXT&egg=$EXT"

@yungezz
Copy link
Member

yungezz commented Aug 19, 2020

hi @fengzhou-msft could you pls help to review?thanks

@qwordy
Copy link
Member Author

qwordy commented Aug 19, 2020

Do not review generated code if I rewrite them in manual folder.

Microsoft Azure CLI 'swiftlet' Extension
==========================================

This package is for the 'swiftlet' extension. Swiftlet is a new Azure Compute offering. Swiftlet is conceived to offer a greatly simplified Azure experience for non-enterprise developers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a . in the end.

@qwordy qwordy merged commit 59eafee into Azure:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PLR] New RP Swiftlet
4 participants