Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS]Support associating an existing user assigned identity for MSI cluster #2015

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

norshtein
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

src/index.json Outdated Show resolved Hide resolved
@arrownj arrownj self-assigned this Jul 14, 2020
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However there is another PR which also update HISTORY.md and version number, this will cause a merge conflict

@Azure Azure deleted a comment from yonzhan Jul 17, 2020
@yungezz
Copy link
Member

yungezz commented Jul 17, 2020

hi @norshtein could you pls resolve conflict for next step?

@norshtein
Copy link
Member Author

Hi @arrownj , @yungezz , I've fixed the merge conflict, can we merge the PR?

Copy link
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JunSun17 JunSun17 merged commit 06c2e3e into Azure:master Jul 17, 2020
@yungezz yungezz added the AKS label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants