Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add wheel preinstallation for job IndexRefDocVerify and fix azure-firewall test recordings #1624

Merged
merged 8 commits into from
Apr 30, 2020

Conversation

haroldrandom
Copy link
Contributor

@haroldrandom haroldrandom commented Apr 29, 2020

Azure CLI no long depends on wheel Azure/azure-cli#13230, have to add it explicitly on CI.

Otherwise, the job would fail https://dev.azure.com/azure-sdk/public/_build/results?buildId=375020&view=results


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@haroldrandom haroldrandom self-assigned this Apr 29, 2020
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@add-wheel#subdirectory=src/$EXT&egg=$EXT"

@haroldrandom haroldrandom added this to the S169 milestone Apr 29, 2020
@haroldrandom haroldrandom changed the title [CI] Add wheel for job IndexRefDocVerify [CI] Add wheel preinstallation for job IndexRefDocVerify Apr 29, 2020
@haroldrandom haroldrandom requested a review from jiasli April 29, 2020 15:20
@haroldrandom haroldrandom changed the title [CI] Add wheel preinstallation for job IndexRefDocVerify [CI] Add wheel preinstallation for job IndexRefDocVerify and fix azure-firewall test recordings Apr 29, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 29, 2020

add to S169

@haroldrandom haroldrandom merged commit 51f8b5d into Azure:master Apr 30, 2020
@haroldrandom haroldrandom deleted the add-wheel branch April 30, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants