blueprint: Import parses unwanted hidden files

[simonkeyd]

This is autogenerated. Please review and update as needed.

Describe the bug

blueprint import will import all files in the artifacts folder including hidden Linux files and might raise an UnicodeDecodeError (eg. for Vim swap files which often include non-ASCII chars)

Command Name
az blueprint import Extension Name: blueprint. Version: 0.3.1.

Errors:

The command failed with an unexpected error. Here is the traceback:
'utf-8' codec can't decode byte 0xfa in position 16: invalid start byte
Traceback (most recent call last):
  File "/home/generic_user/.venv_az/lib/python3.9/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/home/generic_user/.venv_az/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/home/generic_user/.venv_az/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/home/generic_user/.venv_az/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/home/generic_user/.venv_az/lib/python3.9/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/home/generic_user/.venv_az/lib/python3.9/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/home/generic_user/.azure/cliextensions/blueprint/azext_blueprint/custom.py", line 53, in import_blueprint_with_artifacts
    artifact = json.load(artifact_file)
  File "/usr/lib/python3.9/json/__init__.py", line 293, in load
    return loads(fp.read(),
  File "/usr/lib/python3.9/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfa in position 16: invalid start byte

To Reproduce:

• vim generic_blueprint/artifacts/generic_artifact.json
• az blueprint import --name generic_blueprint --input-path ./generic_blueprint --management-group deadbeef-dead-beef-8badf00d1337

Expected Behavior

Import works flawlessly

Environment Summary

Linux-5.10.102.1-microsoft-standard-WSL2-x86_64-with-glibc2.31, Debian GNU/Linux 11 (bullseye)
Python 3.9.2
Installer: PIP

azure-cli 2.37.0

Extensions:
blueprint 0.3.1
resource-graph 2.1.0
serial-console 0.1.1

Dependencies:
msal 1.18.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

[ghost]

Thank you for your feedback. This has been routed to the support team for assistance.

[yonzhan]

route to CXP team

[navba-MSFT]

@simonkeyd Apologies for the late reply. Thanks for reaching out to us and sharing this feedback. We are looking into this issue and we will provide an update. In the meantime, I am following up with the reviewers on your above PR for the approval.

[navba-MSFT]

@simonkeyd Your above PR #4985 has been reviewed and the comments have been added for you to consider. Please check once you get a chance.

Also could you please try the below action plan and check if that helps:

Could you please try to update the Windows system language setting ?

Control panel -> Clock and Region -> Region -> Administrative -> Change system locale -> Check Beta: Use Unicode UTF-8 for worldwide language support.

The change will require reboot. Please let me know if you still face the same issue. Awaiting your reply.

[navba-MSFT]

@simonkeyd I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you are still facing the issue after following my above plan. Awaiting your reply.

[simonkeyd]

@navba-MSFT in most cases one wouldn't want hidden files to be parsed as they can contain unchecked code/content. For example in my particular use case vim swap files are temporary files not meant to be used by program other than vim - not JSON at all.