Skip to content

Commit

Permalink
{CI} Add new comment to explain the reason that pin the wheel to 0.30…
Browse files Browse the repository at this point in the history
….0 (#6842)

* Update test_index.py

* Update pull_request_template.md
  • Loading branch information
wangzelin007 authored Oct 10, 2023
1 parent b3f2c6a commit f5caab7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This checklist is used to make sure that common guidelines for a pull request ar
### General Guidelines

- [ ] Have you run `azdev style <YOUR_EXT>` locally? (`pip install azdev` required)
- [ ] Have you run `python scripts/ci/test_index.py -q` locally?
- [ ] Have you run `python scripts/ci/test_index.py -q` locally? (`pip install wheel==0.30.0` required)

For new extensions:

Expand Down
2 changes: 2 additions & 0 deletions scripts/ci/test_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ def test_extension_filenames(self):
"Extension name mismatch in extensions['{}']. "
"Found an extension in the list with name "
"{}".format(ext_name, item['metadata']['name']))
# Due to https://github.com/pypa/wheel/issues/235 we prevent whls built with 0.31.0 or greater.
# 0.29.0, 0.30.0 are the two previous versions before that release.
parsed_filename = WHEEL_INFO_RE(item['filename'])
p = parsed_filename.groupdict()
self.assertTrue(p.get('name'), "Can't get name for {}".format(item['filename']))
Expand Down

0 comments on commit f5caab7

Please sign in to comment.