[Monitor] add az monitor data-collection commands (#2756)

* Codegen generated with DataCollectionRules Create and Update Pending to manual

* regenerate by hiding DataCollectionRules Create & Update commands and DataCollectionRuleAssociations Create command

* Reuse Codegen generated with DataCollectionRules Create and Update Pending to manual

* add data-collection rule create & update commands

* hide data-collection rule create & update and data-collection rule association

* fix codegen invalid operations_tmpl

* use alias instand of rename in code-gen

* use alias instead of rename for codegen

* add sub command groups for 'monitor data-collection rule'

* add params for monitor data-collection rule performance-counter, windows-event-log, syslog

* consist argument name with sdk name

* use azure-rest-api-spec keywords rename custom function

* use provider name and operation id to rename custom function

* Rename custom functions by readable names

* set monitor data-collection to preview

* regenerate extension with monitor-control-service name

* add monitor controll service test

* update update functions for data_collection_rules and data_collection_rule_associations

* add test file

* add tests

* fix linter and style issues

* rename parameters for rule create

* fix style issues

* add code owner for monitor-control-service

* fix comments issues

* remove _az_debug

* add _az_debug in .gitignore

* state as experimental

* fix readme

* aio not needed

.github/CODEOWNERS

@@ -166,4 +166,6 @@
 
 /src/automation/ @arrownj
 
+/src/monitor-control-service/ @jsntcy @msyyc @kairu-ms
+
 /src/rdbms-connect/ @mjain2 @Juliehzl

.gitignore

@@ -119,3 +119,5 @@ _build/
 
 # Mac desktop service store files
 .DS_Store
+
+_az_debug/

src/monitor-control-service/HISTORY.rst

@@ -0,0 +1,8 @@
+.. :changelog:
+
+Release History
+===============
+
+0.1.0
+++++++
+* Initial release.

src/monitor-control-service/README.md

@@ -0,0 +1,161 @@
+# Azure CLI monitor-control-service Extension
+This is the extension for monitor-control-service
+
+### How to use
+Install this extension using the below CLI command
+```
+az extension add --name monitor-control-service
+```
+
+### Included Features
+#### data-collection rule
+##### Create
+```
+az monitor data-collection rule create --resource-group "myResourceGroup" --location "eastus" --name "myCollectionRule" --data-flows destinations="centralWorkspace" streams="Microsoft-Perf" streams="Microsoft-Syslog" streams="Microsoft-WindowsEvent" --log-analytics name="centralWorkspace" resource-id="/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.OperationalInsights/workspaces/centralTeamWorkspace" --performance-counters name="cloudTeamCoreCounters" counter-specifiers="\\Processor(_Total)\\% Processor Time" counter-specifiers="\\Memory\\Committed Bytes" counter-specifiers="\\LogicalDisk(_Total)\\Free Megabytes" counter-specifiers="\\PhysicalDisk(_Total)\\Avg. Disk Queue Length" sampling-frequency=15 transfer-period="PT1M" streams="Microsoft-Perf" --performance-counters name="appTeamExtraCounters" counter-specifiers="\\Process(_Total)\\Thread Count" sampling-frequency=30 transfer-period="PT5M" streams="Microsoft-Perf" --syslog name="cronSyslog" facility-names="cron" log-levels="Debug" log-levels="Critical" log-levels="Emergency" streams="Microsoft-Syslog" --syslog name="syslogBase" facility-names="syslog" log-levels="Alert" log-levels="Critical" log-levels="Emergency" streams="Microsoft-Syslog" --windows-event-logs name="cloudSecurityTeamEvents" transfer-period="PT1M" streams="Microsoft-WindowsEvent" x-path-queries="Security!" --windows-event-logs name="appTeam1AppEvents" transfer-period="PT5M" streams="Microsoft-WindowsEvent" x-path-queries="System![System[(Level = 1 or Level = 2 or Level = 3)]]" x-path-queries="Application!*[System[(Level = 1 or Level = 2 or Level = 3)]]"
+```
+##### Show
+```
+az monitor data-collection rule show --name "myCollectionRule" --resource-group "myResourceGroup"
+```
+##### List
+List data collection rules by resource group
+```
+az monitor data-collection rule list --resource-group "myResourceGroup"
+```
+List data collection rules by subscription
+```
+az monitor data-collection rule list
+```
+##### Update
+```
+az monitor data-collection rule update --resource-group "myResourceGroup" --name "myCollectionRule" --data-flows destinations="centralWorkspace" streams="Microsoft-Perf" streams="Microsoft-Syslog" streams="Microsoft-WindowsEvent" --log-analytics name="centralWorkspace" resource-id="/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.OperationalInsights/workspaces/centralTeamWorkspace" --performance-counters name="appTeamExtraCounters" counter-specifiers="\\Process(_Total)\\Thread Count" sampling-frequency=30 transfer-period="PT5M" streams="Microsoft-Perf" --syslog name="cronSyslog" facility-names="cron" log-levels="Debug" log-levels="Critical" log-levels="Emergency" streams="Microsoft-Syslog" --windows-event-logs name="cloudSecurityTeamEvents" transfer-period="PT1M" streams="Microsoft-WindowsEvent" x-path-queries="Security!"
+```
+##### Delete
+```
+az monitor data-collection rule delete --name "myCollectionRule" --resource-group "myResourceGroup"
+```
+
+#### data-collection rule data-flow
+##### List
+```
+az monitor data-collection rule data-flow list --rule-name "myCollectionRule" --resource-group "myResourceGroup"
+```
+##### Add
+```
+az monitor data-collection rule data-flow add --rule-name "myCollectionRule" --resource-group "myResourceGroup" --destinations XX3 XX4 --streams "Microsoft-Perf" "Microsoft-WindowsEvent"
+```
+
+#### data-collection rule log-analytics
+##### List
+```
+az monitor data-collection rule log-analytics list --rule-name "myCollectionRule" --resource-group "myResourceGroup"
+```
+##### Show
+```
+az monitor data-collection rule log-analytics show --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "centralWorkspace"
+```
+##### Add
+```
+az monitor data-collection rule log-analytics add --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "workspace2" --resource-id "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.OperationalInsights/workspaces/workspace2"
+```
+##### Delete
+```
+az monitor data-collection rule log-analytics delete --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "workspace2"
+```
+##### Update
+```
+az monitor data-collection rule log-analytics update --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "workspace2" --resource-id "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.OperationalInsights/workspaces/anotherWorkspace"
+```
+
+#### data-collection rule performance-counter
+##### List
+```
+az monitor data-collection rule performance-counter list --rule-name "myCollectionRule" --resource-group "myResourceGroup"
+```
+##### Show
+```
+az monitor data-collection rule performance-counter show --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "appTeamExtraCounters"
+```
+##### Add
+```
+az monitor data-collection rule performance-counter add --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "team2ExtraCounters" --streams "Microsoft-Perf" --counter-specifiers "\\Process(_Total)\\Thread Count" "\\LogicalDisk(_Total)\\Free Megabytes" --sampling-frequency 30 --transfer-period PT15M
+```
+##### Delete
+```
+az monitor data-collection rule performance-counter delete --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "team2ExtraCounters"
+```
+##### Update
+```
+az monitor data-collection rule performance-counter update --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "team2ExtraCounters" --transfer-period PT1M
+```
+
+#### data-collection rule windows-event-log
+##### List
+```
+az monitor data-collection rule windows-event-log list --rule-name "myCollectionRule" --resource-group "myResourceGroup"
+```
+##### Show
+```
+az monitor data-collection rule windows-event-log show --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "appTeam1AppEvents"
+```
+##### Add
+```
+az monitor data-collection rule windows-event-log add --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "appTeam1AppEvents" --transfer-period "PT1M" --streams "Microsoft-WindowsEvent" --x-path-queries "Application!*[System[(Level = 1 or Level = 2 or Level = 3)]]" "System![System[(Level = 1 or Level = 2 or Level = 3)]]"
+```
+##### Delete
+```
+az monitor data-collection rule windows-event-log delete --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "appTeam1AppEvents"
+```
+##### Update
+```
+az monitor data-collection rule windows-event-log update --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "appTeam1AppEvents" --x-path-queries "Application!*[System[(Level = 1 or Level = 2 or Level = 3)]]"
+```
+
+#### data-collection rule syslog
+##### List
+```
+az monitor data-collection rule syslog list --rule-name "myCollectionRule" --resource-group "myResourceGroup"
+```
+##### Show
+```
+az monitor data-collection rule syslog show --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "syslogBase"
+```
+##### Add
+```
+az monitor data-collection rule syslog add --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "syslogBase" --facility-names "syslog" --log-levels "Alert" "Critical" --streams "Microsoft-Syslog"
+```
+##### Delete
+```
+az monitor data-collection rule syslog delete --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "syslogBase"
+```
+##### Update
+```
+az monitor data-collection rule syslog update --rule-name "myCollectionRule" --resource-group "myResourceGroup" --name "syslogBase" --facility-names "syslog" --log-levels "Emergency" "Critical"
+```
+
+#### data-collection rule association
+##### Create
+```
+az monitor data-collection rule association create --name "myAssociation" --rule-id "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Insights/dataCollectionRules/myCollectionRule" --resource "subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVm"
+```
+##### Show
+```
+az monitor data-collection rule association show --name "myAssociation" --resource "subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVm"
+```
+##### Update
+```
+az monitor data-collection rule association update --name "myAssociation" --rule-id "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Insights/dataCollectionRules/myCollectionRule" --resource "subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVm"
+```
+##### List
+List associations for specified data collection rule
+```
+az monitor data-collection rule association list --rule-name "myCollectionRule" --resource-group "myResourceGroup" 
+```
+List associations for specified resource
+```
+az monitor data-collection rule association list --resource "subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVm"
+```
+##### Delete
+```
+az monitor data-collection rule association delete --name "myAssociation" --resource "subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Compute/virtualMachines/myVm"
+```

src/monitor-control-service/azext_amcs/__init__.py

@@ -0,0 +1,50 @@
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is
+# regenerated.
+# --------------------------------------------------------------------------
+
+from azure.cli.core import AzCommandsLoader
+from azext_amcs.generated._help import helps  # pylint: disable=unused-import
+try:
+    from azext_amcs.manual._help import helps  # pylint: disable=reimported
+except ImportError:
+    pass
+
+
+class MonitorClientCommandsLoader(AzCommandsLoader):
+
+    def __init__(self, cli_ctx=None):
+        from azure.cli.core.commands import CliCommandType
+        from azext_amcs.generated._client_factory import cf_monitor_control_service_cl
+        monitor_control_service_custom = CliCommandType(
+            operations_tmpl='azext_amcs.custom#{}',
+            client_factory=cf_monitor_control_service_cl)
+        parent = super(MonitorClientCommandsLoader, self)
+        parent.__init__(cli_ctx=cli_ctx, custom_command_type=monitor_control_service_custom)
+
+    def load_command_table(self, args):
+        from azext_amcs.generated.commands import load_command_table
+        load_command_table(self, args)
+        try:
+            from azext_amcs.manual.commands import load_command_table as load_command_table_manual
+            load_command_table_manual(self, args)
+        except ImportError:
+            pass
+        return self.command_table
+
+    def load_arguments(self, command):
+        from azext_amcs.generated._params import load_arguments
+        load_arguments(self, command)
+        try:
+            from azext_amcs.manual._params import load_arguments as load_arguments_manual
+            load_arguments_manual(self, command)
+        except ImportError:
+            pass
+
+
+COMMAND_LOADER_CLS = MonitorClientCommandsLoader

src/monitor-control-service/azext_amcs/action.py

@@ -0,0 +1,17 @@
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is
+# regenerated.
+# --------------------------------------------------------------------------
+# pylint: disable=wildcard-import
+# pylint: disable=unused-wildcard-import
+
+from .generated.action import *  # noqa: F403
+try:
+    from .manual.action import *  # noqa: F403
+except ImportError:
+    pass

src/monitor-control-service/azext_amcs/azext_metadata.json

@@ -0,0 +1,4 @@
+{
+    "azext.isPreview": true,
+    "azext.minCliCoreVersion": "2.15.0"
+}

src/monitor-control-service/azext_amcs/custom.py

@@ -0,0 +1,17 @@
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is
+# regenerated.
+# --------------------------------------------------------------------------
+# pylint: disable=wildcard-import
+# pylint: disable=unused-wildcard-import
+
+from .generated.custom import *  # noqa: F403
+try:
+    from .manual.custom import *  # noqa: F403
+except ImportError:
+    pass

src/monitor-control-service/azext_amcs/generated/__init__.py

@@ -0,0 +1,12 @@
+# coding=utf-8
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is
+# regenerated.
+# --------------------------------------------------------------------------
+
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)

src/monitor-control-service/azext_amcs/generated/_client_factory.py

@@ -0,0 +1,24 @@
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is
+# regenerated.
+# --------------------------------------------------------------------------
+
+
+def cf_monitor_control_service_cl(cli_ctx, *_):
+    from azure.cli.core.commands.client_factory import get_mgmt_service_client
+    from azext_amcs.vendored_sdks.amcs import MonitorClient
+    return get_mgmt_service_client(cli_ctx,
+                                   MonitorClient)
+
+
+def cf_data_collection_rule_association(cli_ctx, *_):
+    return cf_monitor_control_service_cl(cli_ctx).data_collection_rule_associations
+
+
+def cf_data_collection_rule(cli_ctx, *_):
+    return cf_monitor_control_service_cl(cli_ctx).data_collection_rules