Skip to content

Commit

Permalink
fix aks draft crash on windows (#5345)
Browse files Browse the repository at this point in the history
  • Loading branch information
FumingZhang authored Sep 15, 2022
1 parent 5336651 commit 0f50ab9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

0.5.101
+++++++

* Fix `az aks draft` command crashed on windows during binary check, see issue `\#5336 <https://github.com/Azure/azure-cli-extensions/issues/5336>`_.
* Update to use 2022-08-02-preview api version.

0.5.100
Expand Down
3 changes: 2 additions & 1 deletion src/aks-preview/azext_aks_preview/aks_draft/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ def _get_filename() -> Optional[str]:
logging.error('Cannot find a suitable download for the current system architecture. Draft only supports AMD64 and ARM64.')
return None

return f'draft-{operating_system}-{architecture}'
file_suffix = ".exe" if operating_system == "windows" else ""
return f'draft-{operating_system}-{architecture}{file_suffix}'


# Returns path to existing draft binary, None otherwise
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import setup, find_packages

VERSION = "0.5.100"
VERSION = "0.5.101"
CLASSIFIERS = [
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
Expand Down

0 comments on commit 0f50ab9

Please sign in to comment.