[AKS] refine creating TA binding commands (#5572)

* [AKS] refine creating TA binding commands * add tests for TA * history * refine * recording * remove live only Co-authored-by: Yitong Feng <[email protected]>
Azure · Nov 24, 2022 · 0344559 · 0344559
1 parent 3c5a707
commit 0344559
Show file tree

Hide file tree

Showing 5 changed files with 1,414 additions and 7 deletions.
diff --git a/src/aks-preview/HISTORY.rst b/src/aks-preview/HISTORY.rst
@@ -14,6 +14,7 @@ Pending
 
 * Fix `az aks update` command failing on updating the ssh key value if cluster was created without ssh key, see issue `\#5559 <https://github.com/Azure/azure-cli-extensions/issues/5559>`_.
 * Mark "--enable-pod-security-policy" deprecated
+* Deny create request if binding existed for command "trustedaccess rolebinding create"
 * Support AAD clusters for "az aks kollect"
 
 0.5.115

diff --git a/src/aks-preview/azext_aks_preview/custom.py b/src/aks-preview/azext_aks_preview/custom.py
@@ -34,6 +34,10 @@
     PasswordCredential,
     ServicePrincipalCreateParameters,
 )
+from azure.core.exceptions import (
+    ResourceNotFoundError,
+    HttpResponseError,
+)
 from dateutil.parser import parse
 from dateutil.relativedelta import relativedelta
 from knack.log import get_logger
@@ -2324,6 +2328,15 @@ def aks_trustedaccess_role_binding_create(cmd, client, resource_group_name, clus
         resource_type=CUSTOM_MGMT_AKS_PREVIEW,
         operation_group="trusted_access_role_bindings",
     )
+    existedBinding = None
+    try:
+        existedBinding = client.get(resource_group_name, cluster_name, role_binding_name)
+    except ResourceNotFoundError:
+        logger.warning("TrustedAccess RoleBinding " + role_binding_name + " not existed, will create a new one!")
+
+    if existedBinding:
+        raise Exception("TrustedAccess RoleBinding " + role_binding_name + " already existed, please use 'az aks trustedaccess rolebinding update' command to update!")
+
     roleList = roles.split(',')
     roleBinding = TrustedAccessRoleBinding(source_resource_id=source_resource_id, roles=roleList)
     return client.create_or_update(resource_group_name, cluster_name, role_binding_name, roleBinding)