Skip to content

Commit

Permalink
Changed the default value for eventdeliveryschema parameter to match …
Browse files Browse the repository at this point in the history
…the input event schema. (#189)

* Added eventgrid preview extension to index.json.

* Made the hash lowercase.

* Regenerated using Wheel 0.30

* Updating index metadata to match with what's in the package.

* Updated the description to match what's in the package.

* Added minCliCoreVersion in index.json to match with the metadata in the package.

* Changed the default value for eventdeliveryschema parameter to match the input event schema.

* Updated version in index.json and fixed the default in the function argument list.

* Changing SHA256digest to lower case.

* Regenerated extension with 0.30.0 of wheel to resolve CI errors.
  • Loading branch information
kalyanaj authored and williexu committed May 24, 2018
1 parent 105adc3 commit 02848ea
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/eventgrid/azext_eventgrid/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def load_arguments(self, _):
with self.argument_context('eventgrid event-subscription') as c:
c.argument('topic_name', help='Name of the Event Grid topic', options_list=['--topic-name'], completer=get_resource_name_completion_list('Microsoft.EventGrid/topics'))
c.argument('event_subscription_name', arg_type=name_type, help='Name of the event subscription')
c.argument('event_delivery_schema', arg_type=get_enum_type(['eventgridschema', 'inputeventschema', 'cloudeventv01schema'], default='eventgridschema'), help='Schema in which events should be delivered for this event subscription. By default, events are delivered in the eventgridschema. To make EventGrid deliver events in the same schema as the published event schema, use customeventschema as the value for this parameter. To make EventGrid deliver events in the Cloud Events V0.1 schema, use cloudeventv01schema as the value for this parameter.')
c.argument('event_delivery_schema', arg_type=get_enum_type(['eventgridschema', 'inputeventschema', 'cloudeventv01schema'], default='inputeventschema'), help='The schema in which events should be delivered for this event subscription. By default, events are delivered in the same schema in which they are published (inputeventschema).')
c.argument('max_delivery_attempts', help="Maximum number of delivery attempts. Must be a number between 1 and 30.")
c.argument('event_ttl', help="Event time to live (in minutes). Must be a number between 1 and 1440.")
c.argument('deadletter_endpoint', help="The Azure resource ID of an Azure Storage blob container destination where EventGrid should deadletter undeliverable events for this event subscription.")
Expand Down
2 changes: 1 addition & 1 deletion src/eventgrid/azext_eventgrid/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def cli_eventgrid_event_subscription_create(
is_subject_case_sensitive=False,
max_delivery_attempts=30,
event_ttl=1440,
event_delivery_schema=EVENTGRID_SCHEMA,
event_delivery_schema=INPUT_EVENT_SCHEMA,
deadletter_endpoint=None,
labels=None):
# Construct RetryPolicy based on max_delivery_attempts and event_ttl
Expand Down
2 changes: 1 addition & 1 deletion src/eventgrid/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "0.2.0"
VERSION = "0.2.1"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down
8 changes: 4 additions & 4 deletions src/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -793,9 +793,9 @@
],
"eventgrid": [
{
"filename": "eventgrid-0.2.0-py2.py3-none-any.whl",
"sha256Digest": "c26ee3b5bc9e8f109b370ec20b25697d71fc9d4e8700f5f03e452b66c9eaedb2",
"downloadUrl": "https://eventgridcliextension.blob.core.windows.net/cli/eventgrid-0.2.0-py2.py3-none-any.whl",
"filename": "eventgrid-0.2.1-py2.py3-none-any.whl",
"sha256Digest": "e7acf947b1d7ab307a21897a8a9cb859575fe880c84fe04e191a5e00d7e4814a",
"downloadUrl": "https://eventgridcliextension.blob.core.windows.net/cli/eventgrid-0.2.1-py2.py3-none-any.whl",
"metadata": {
"azext.minCliCoreVersion": "2.0.24",
"azext.isPreview": true,
Expand Down Expand Up @@ -834,7 +834,7 @@
"metadata_version": "2.0",
"name": "eventgrid",
"summary": "Support for Azure EventGrid 2018-05-01-preview features",
"version": "0.2.0"
"version": "0.2.1"
}
}
],
Expand Down

0 comments on commit 02848ea

Please sign in to comment.