Add --deps-from to azdev setup and use requirements file to resolve dependencies by default #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Can you fire another PR to test against this PR? |
fengzhou-msft
commented
May 11, 2020
azdev/operations/setup.py
Outdated
Comment on lines
130
to
131
| if system == 'Windows': | ||
| system = system.lower() |
There was a problem hiding this comment.
may not need this as windows file name is case-insensitive, will test.
2 tasks
Test PR submitted: Azure/azure-cli#13431 |
| "Installing `azure-cli-testsdk`..." | ||
| ) | ||
| import platform | ||
| system = platform.system() |
There was a problem hiding this comment.
Why not?
Suggested change
| system = platform.system() | |
| system = platform.system().lower() |
There was a problem hiding this comment.
For Linux/Mac, need capitalized first letter. I have verified that on Windows, *.Windows.txt also works when the file name is *.windows.txt. So I removed the lower() operation.
haroldrandom
approved these changes
May 13, 2020
fengzhou-msft
changed the title
jiasli
reviewed
May 13, 2020
| # Resolve dependencies from setup.py files. | ||
| # command modules have dependency on azure-cli-core so install this first | ||
| pip_cmd( | ||
| "install -q -e {}/src/azure-cli-nspkg".format(cli_path), |
There was a problem hiding this comment.
I suggest we get rid of this thing as soon as possible once we move to PEP 420 Azure/azure-cli#13293. 😆 azure-cli-nspkg was introduced in Azure/azure-cli#2951.
jiasli
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development part to solve Azure/azure-cli#9781.
This PR adds
--deps-fromoption toazev setup. By default, use therequirements.*.txtfile to resolve dependencies for Azure CLI project. Specify--deps-from setup.pyto usesetup.pyfiles to resolve dependencies, which is the previous behavior.