Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mkdir for output dir if not exists #364

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Mkdir for output dir if not exists #364

merged 1 commit into from
Feb 28, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 28, 2023

This PR changes the behavior of -o that it will create the output directory if not existed.

stemaMSFT
stemaMSFT approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@stemaMSFT stemaMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Curious if we'll be able to see output directory creation within our telemetry as well.

@stemaMSFT stemaMSFT merged commit bfd11b2 into Azure:main Feb 28, 2023
@magodo
Copy link
Collaborator Author

magodo commented Mar 1, 2023

@stemaMSFT Currently no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stemaMSFT stemaMSFT stemaMSFT approved these changes

@ms-henglu ms-henglu Awaiting requested review from ms-henglu

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magodo @stemaMSFT