Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azd template: devcenter with azure deployment environments #188

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

lopezleandro03
Copy link
Contributor

Your template repository

Place your template repository link here: https://github.com/lopezleandro03/azd-devcenter

- [x] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/static/templates.json that includes:
- [x] **Template title** - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
- [x] **Description** - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
- [x] **Architecture Diagram or Application Screenshot** - Used as display image for gallery card. The image should include all services and their connections ([example](https://github.com/Azure-Samples/todo-csharp-sql/blob/main/assets/resources.png)). You should add the image to the `website/src/data/images/`.
- [x] **Link to Author's GitHub or other relevant website** - Used for attribution
- [x] **Author's Name** -  Name to credit on the gallery card
- [x] **Link to template source** - Link to the template GitHub repo 
- [x] **Tags** - One or more [tags](https://github.com/Azure/awesome-azd/blob/main/website/src/data/tags.tsx) representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!

The project was started with azd init, using azd from the get go.

@gkulin
Copy link
Collaborator

gkulin commented Aug 31, 2023

thanks for your contribution!

@v-xuto Vendor would you mind testing this template?

@v-xuto
Copy link
Member

v-xuto commented Sep 1, 2023

thanks for your contribution!

@v-xuto Vendor would you mind testing this template?

Sure. We will start testing this template today.

@v-xuto
Copy link
Member

v-xuto commented Sep 4, 2023

@lopezleandro03, @gkulin We have finished this template test, and we filed one issue. Please review.

@lopezleandro03
Copy link
Contributor Author

lopezleandro03 commented Sep 8, 2023

Hi @v-xuto, @gkulin the issue is now closed. The testing team was able deploy all the infra and deploy ARM/Bicep based environments using Azure Deployment Environments which is the goal of this project. Documentation has been updated accordingly to the feedback gotten.

What's the next step?

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @jongio to ask for approval or other suggestions.

@v-xuto
Copy link
Member

v-xuto commented Sep 11, 2023

@hemarina Issue lopezleandro03/azd-devcenter#4 has been fixed, currently this template has no issues.

@jongio
Copy link
Member

jongio commented Sep 12, 2023

looks good

@gkulin gkulin merged commit 501370f into Azure:main Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants