Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tag should contains all latest apiVersion swagger file #78

Merged
merged 16 commits into from
Feb 23, 2022
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.8.5

- To make sure default tag contains the latest apiVersion swagger. Add two rules NOT_LATEST_API_VERSION_IN_DEFAULT_TAG and MISSING_APIS_IN_DEFAULT_TAG.

## 0.8.3

- Bug fix. avoid infinite loop. When find the nearest readme
Expand Down
16 changes: 16 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,22 @@ The management plane swagger JSON file does not match its folder path. Make sure

To solve this warning, you should make sure manager plane swagger located in resource-manager folder.

### MISSING_APIS_IN_DEFAULT_TAG

Level: ERROR

The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.

To fix this error. You should add the missing API swaggers to the default tag. If the missing API swaggers are deprecated, in this case this error could be ignored.

### NOT_LATEST_API_VERSION_IN_DEFAULT_TAG

Level: ERROR

The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag.

To fix this error. You should add the latest API version swaggers to the default tag or change default tag to reference latest api version tag.

## Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a
Expand Down
164 changes: 82 additions & 82 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
@@ -1,88 +1,88 @@
trigger:
- master
- master

jobs:
- job: Test
strategy:
matrix:
Linux.Node10:
node.version: 10.x
vm.image: 'Ubuntu 16.04'
Linux.Node12:
node.version: 12.x
vm.image: 'Ubuntu 16.04'
Win.Node10:
node.version: 10.x
vm.image: 'vs2017-win2016'
Win.Node12:
node.version: 12.x
vm.image: 'vs2017-win2016'
pool:
vmImage: $(vm.image)
steps:
- task: NodeTool@0
displayName: 'Install Node'
inputs:
versionSpec: $(node.version)
- script: npm install
- task: Npm@1
displayName: 'npm test'
inputs:
command: custom
verbose: false
customCommand: test
- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
testResultsFiles: '**/test-results.xml'
testRunTitle: 'Test results for JavaScript'
- task: PublishCodeCoverageResults@1
condition: succeededOrFailed()
inputs:
codeCoverageTool: Cobertura
summaryFileLocation: '$(System.DefaultWorkingDirectory)/**/*coverage.xml'
reportDirectory: '$(System.DefaultWorkingDirectory)/**/coverage'
- job: Build
pool:
vmImage: 'Ubuntu 16.04'
steps:
- task: Npm@1
displayName: 'npm pack'
inputs:
command: custom
verbose: false
customCommand: pack
- task: CopyFiles@2
displayName: 'Copy Files to: drop'
inputs:
Contents: '*.tgz'
TargetFolder: drop
- task: PublishBuildArtifacts@1
inputs:
pathtoPublish: $(Build.SourcesDirectory)/drop
- job: Test
strategy:
matrix:
Linux.Node10:
node.version: 10.x
vm.image: 'Ubuntu 18.04'
Linux.Node12:
node.version: 12.x
vm.image: 'Ubuntu 18.04'
Win.Node10:
node.version: 10.x
vm.image: 'vs2017-win2016'
Win.Node12:
node.version: 12.x
vm.image: 'vs2017-win2016'
pool:
vmImage: $(vm.image)
steps:
- task: NodeTool@0
displayName: 'Install Node'
inputs:
versionSpec: $(node.version)
- script: npm install
- task: Npm@1
displayName: 'npm test'
inputs:
command: custom
verbose: false
customCommand: test
- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
testResultsFiles: '**/test-results.xml'
testRunTitle: 'Test results for JavaScript'
- task: PublishCodeCoverageResults@1
condition: succeededOrFailed()
inputs:
codeCoverageTool: Cobertura
summaryFileLocation: '$(System.DefaultWorkingDirectory)/**/*coverage.xml'
reportDirectory: '$(System.DefaultWorkingDirectory)/**/coverage'
- job: Build
pool:
vmImage: 'Ubuntu 18.04'
steps:
- task: Npm@1
displayName: 'npm pack'
inputs:
command: custom
verbose: false
customCommand: pack
- task: CopyFiles@2
displayName: 'Copy Files to: drop'
inputs:
Contents: '*.tgz'
TargetFolder: drop
- task: PublishBuildArtifacts@1
inputs:
pathtoPublish: $(Build.SourcesDirectory)/drop

- job: Windows
pool:
vmImage: "windows-2019"
- job: Windows
pool:
vmImage: 'windows-2019'

steps:
- task: ea576cd4-c61f-48f8-97e7-a3cb07b90a6f@2 # CredScan@2
inputs:
toolMajorVersion: 'V2'
steps:
- task: ea576cd4-c61f-48f8-97e7-a3cb07b90a6f@2 # CredScan@2
inputs:
toolMajorVersion: 'V2'

- task: f5679091-e6da-4974-a8dc-0eec03a8ea63@1 # PostAnalysis@1
inputs:
AllTools: false
APIScan: false
BinSkim: false
CodesignValidation: false
CredScan: true
FortifySCA: false
FxCop: false
ModernCop: false
PoliCheck: false
RoslynAnalyzers: false
SDLNativeRules: false
Semmle: false
TSLint: false
ToolLogsNotFoundAction: 'Standard'
- task: f5679091-e6da-4974-a8dc-0eec03a8ea63@1 # PostAnalysis@1
inputs:
AllTools: false
APIScan: false
BinSkim: false
CodesignValidation: false
CredScan: true
FortifySCA: false
FxCop: false
ModernCop: false
PoliCheck: false
RoslynAnalyzers: false
SDLNativeRules: false
Semmle: false
TSLint: false
ToolLogsNotFoundAction: 'Standard'
Loading