Adding custom polymorphic discriminator support #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an extension that lets you specify the discriminator value for a derived type, plus test coverage.
Custom discriminators already worked as-is for C#, Node.js, and Java. Ruby required more work to get right. The approach I took is modeled loosely off the one used in the generated Node.js code.
stankovski
added a commit
that referenced
this pull request
Nov 10, 2015
Adding custom polymorphic discriminator support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new extension,
x-ms-discriminator-value, that lets you model type hierarchies where the serialized name used to identify a sub-type can differ from the sub-type's name. The value flows through to theCompositeType.SerializedNameproperty. The generated code for C#, Node.js, and Java can already handle having aSerializedNamediffer fromName, but it took more work to support it in Ruby.Related issue: #366