Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Use host default value #676

Merged
merged 2 commits into from
Jun 25, 2020
Merged

[v6] Use host default value #676

merged 2 commits into from
Jun 25, 2020

Conversation

joheredi
Copy link
Member

When $host has a default value specified use it as the endpoint.

We have a bug when finding the $host parameter in which the find function always returned undefined 😞

Fixing this to actually set endpoint with the $host default value if available.

This fix will also workaround Issue Azure/azure-sdk-for-js/issues/9700 as replaceAll won't be called for the host since we'd effectivly be filling out {$host} in Autorest by setting the endpoint

@joheredi joheredi requested a review from chradek June 25, 2020 21:16
@joheredi joheredi requested a review from daviwil as a code owner June 25, 2020 21:16
@joheredi joheredi merged commit 6e81da3 into Azure:v6 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants