[v6] include optional parameters with no media type in mediatype-specific options bag #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bterlson found an issue where optional parameters were being ignored when an operation supports multiple media types.
It turns out our code that generated the mediatype-specific options bags checked if a parameter's mediatype matched the overload's mediatype. This meant we were excluding optional parameters that applied to all overloads.
I added an Open API V3 model to generate a client that exercises these conditions. I'm not sure if it's possible to encounter this with an Open API V2 (swagger) file given how you specify multiple content-types there.