[v6] improve contentType detection in overloaded methods #619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeremymeng found an issue where when an operation has overloads,
contentType
is misidentified in the arguments list.The reason for this is because previously, we were detecting which argument is the contentType by looking at the code model's
operation.requests
array and getting the index from that. However, if all the overloads share parameters, those parameters are onoperation.parameters
. This meant that if a parameter fromoperation.parameters
showed up in the overload before the ones inoperation.requests[i].parameters
, the contentType lookup would be incorrect.In some cases (though I haven't been able to identify when) this actually does occur. For example, in form-recognizer. Interestingly when I tried copying the operation that had an issue in form-recognizer into a new swagger model and generated a client for it,
contentType
was always the first parameter. I was able to verify this change fixes the issue by regenerating form-recognizer.You can see the issue in the generated code here:
After this change,
args[1]
is correctly checked in the if/else statements for contentType.